localtime is defined in the header, but has no implementation

[zhuowei]

the localtime function is present in wasi-sysroot's headers, but not in the actual libc library, so programs calling localtime fails during linking:

#include <time.h>

int main() {
	time_t a;
	localtime(&a);
}

zhuowei@zhuowei-laptop:~/wasi-sdk/bin$ ./clang-8 localtime.c 
wasm-ld: error: /tmp/localtime-230b9c.o: undefined symbol: localtime
clang-8: error: lld command failed with exit code 1 (use -v to see invocation)

Either the localtime function should be removed from the header, or an implementation should be added to the libc.

[ericsink]

I bumped into this problem too. Just to add more information:

The implementation does seem to be present:

libc-top-half/musl/src/time/localtime.c

So I'm guessing this is some kind of (possibly simple) problem with the build.

[kubkon]

As @ericsink rightly pointed out, the implementation is there, but the symbol is missing from the build as can be seen in defined-symbols.txt (or rather the lack of localtime).

[kubkon]

Fixed in #22.