Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: quota and group manual CSVs should use persistent_path #162

Open
zoidy opened this issue Sep 8, 2021 · 0 comments
Open

Enhancement: quota and group manual CSVs should use persistent_path #162

zoidy opened this issue Sep 8, 2021 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@zoidy
Copy link
Collaborator

zoidy commented Sep 8, 2021

Summary
Currently, the manual override files for portal and quota are set in config/figshare.ini to be config/portal_manual.csv and config/quota_manual.csv respectively. These files should not be stored in config. Instead they should be stored in the directory identified by the persistent_storage setting in figshare.ini. Currently, in production, this has been done at the file system level by a symlink to the persistent_storage folder. However, this could cause some inconvenience if we need to re-deploy ReQUIAM as the link would need to be manually created. More generally, it would be good to have all customized files consistently live on persistent_storage which is defined by code rather than done at the file system level using links.

Objectives
quota_manual.csv and portal_manual.csv should be stored in the persistent_storage directory.

Proposal
Modify the code to use persistent_storage instead of the hard-coded config folder

Testing notes

  • Test that the folder is writable
  • Test that existing csv can be read from that folder

Additional notes

Implemented in: TBD

@zoidy zoidy added enhancement New feature or request good first issue Good for newcomers labels Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant