-
-
Notifications
You must be signed in to change notification settings - Fork 291
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: naomiaro/waveform-playlist
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: Treora/waveform-playlist
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
Can’t automatically merge.
Don’t worry, you can still create the pull request.
- 19 commits
- 11 files changed
- 1 contributor
Commits on Oct 21, 2019
-
Configuration menu - View commit details
-
Copy full SHA for fd42f6a - Browse repository at this point
Copy the full SHA fd42f6aView commit details -
Configuration menu - View commit details
-
Copy full SHA for aa947f9 - Browse repository at this point
Copy the full SHA aa947f9View commit details -
Configuration menu - View commit details
-
Copy full SHA for ad5d18c - Browse repository at this point
Copy the full SHA ad5d18cView commit details -
Configuration menu - View commit details
-
Copy full SHA for b5c9a33 - Browse repository at this point
Copy the full SHA b5c9a33View commit details
Commits on Nov 4, 2019
-
Set "box-sizing: border-box" for annotation boxes
To make annotations the correct size. Note the problem did not appear in the examples because there Bootstrap already sets this attribute for all elements.
Configuration menu - View commit details
-
Copy full SHA for 2d94350 - Browse repository at this point
Copy the full SHA 2d94350View commit details -
Do not round pixel values, fixes misalignments
Decimals are fine in CSS. Also, sometimes small misalignments appeared. The reason was that the width calculation of annotation boxes ignored the rounding of the 'left' value. For example, assuming pixPerSec=1 for simplicity, a note ranging from 5.4s to 8.8s (= 3.4 seconds) would lead to 'left: 5px; width: 3px', whereas a width of 4px would got the right side closer to the desired 8.8px. Instead of fixing this calculation, it seemed better to remove the rounding altogether.
Configuration menu - View commit details
-
Copy full SHA for 3eaf2a7 - Browse repository at this point
Copy the full SHA 3eaf2a7View commit details -
Fix selection cursor misalignment
Just set the width to 1px for point selections, instead of always adding 1px to the width, which was inappropriate for segments. Also, for a point, subtract half the width to center the line. Refactor a little to more clearly distinguish the two scenarios.
Configuration menu - View commit details
-
Copy full SHA for d1672a5 - Browse repository at this point
Copy the full SHA d1672a5View commit details -
Don't break when cursor is not (yet) rendered.
Problem occured in practice, not sure due to which factors.
Configuration menu - View commit details
-
Copy full SHA for add85cb - Browse repository at this point
Copy the full SHA add85cbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 352850e - Browse repository at this point
Copy the full SHA 352850eView commit details
Commits on Nov 17, 2019
-
Instead of creating negative width, create a square annotation centered at the annotated point.
Configuration menu - View commit details
-
Copy full SHA for 631538a - Browse repository at this point
Copy the full SHA 631538aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4f537fe - Browse repository at this point
Copy the full SHA 4f537feView commit details -
Configuration menu - View commit details
-
Copy full SHA for e2ad86c - Browse repository at this point
Copy the full SHA e2ad86cView commit details -
This way (at least) Chromium gives us mouse events even if the cursor is outside the document or browser window (while the button is pressed).
Configuration menu - View commit details
-
Copy full SHA for 621f633 - Browse repository at this point
Copy the full SHA 621f633View commit details -
Configuration menu - View commit details
-
Copy full SHA for 047e5d1 - Browse repository at this point
Copy the full SHA 047e5d1View commit details
Commits on Nov 18, 2019
-
Configuration menu - View commit details
-
Copy full SHA for f445ae7 - Browse repository at this point
Copy the full SHA f445ae7View commit details -
Configuration menu - View commit details
-
Copy full SHA for ee0e155 - Browse repository at this point
Copy the full SHA ee0e155View commit details -
Configuration menu - View commit details
-
Copy full SHA for 174d838 - Browse repository at this point
Copy the full SHA 174d838View commit details -
Revise playlist’s 'select' handler and seek()
- 'select' event should always update selection, also if isPlaying(). - emit 'timeupdate' and redraw in seek(), not in 'select' handler. - deduplicate code between 'select' handler and seek(). I hope these changes do not cause subtle issues in untested use cases.
Configuration menu - View commit details
-
Copy full SHA for b3b7339 - Browse repository at this point
Copy the full SHA b3b7339View commit details -
Revises commit 4f537fe to clamp to the whole playlist’s duration instead of to the individual track the cursor happens to be clicking on.
Configuration menu - View commit details
-
Copy full SHA for 1d41952 - Browse repository at this point
Copy the full SHA 1d41952View commit details
There are no files selected for viewing