-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve test duration by only running one frontend test per color scheme #370
Conversation
Playwright visual snapshot differences were detected.View the Playwright report to review the visual differences. |
e24203b
to
5ad4f61
Compare
/approve-snapshots |
Updating snapshots. Click here to see the status. |
/approve-snapshots |
What? Is the additional time that much more. I believe that most of the time is lost in misplaced retires and long build times, which are not there on second run. |
Of course the second run is faster because a lot is already cached in nix but this still saves a good 2 minutes, from ~14m to ~12m. Especially when a test fails because of code changes, it doesn't have to fail twice because of theming. The different color screenshots are only to verify the theming and don't affect functionality. So any minute saved here speeds up testing. Especially with the merge queue all CI tests have to run twice, which effectively doubles the whole test duration. |
We should probably do a visual walkthrough through the app in light and dark to get Screenshots that doesn't take much time in builds and only test most stuff in one theme, right? |
That would be a possibility, yes |
6c6240b
to
3eaa7f2
Compare
3eaa7f2
to
d504bb8
Compare
No description provided.