Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test duration by only running one frontend test per color scheme #370

Merged
merged 5 commits into from
Feb 24, 2025

Conversation

MSchmoecker
Copy link
Member

No description provided.

Copy link

github-actions bot commented Feb 22, 2025

Playwright visual snapshot differences were detected.

View the Playwright report to review the visual differences.
To approve the snapshot changes and update the snapshots, please comment: /approve-snapshots

@MSchmoecker
Copy link
Member Author

/approve-snapshots

@thymis-github-app
Copy link
Contributor

thymis-github-app bot commented Feb 22, 2025

Updating snapshots. Click here to see the status.

@MSchmoecker
Copy link
Member Author

/approve-snapshots

@elikoga
Copy link
Member

elikoga commented Feb 22, 2025

What? Is the additional time that much more. I believe that most of the time is lost in misplaced retires and long build times, which are not there on second run.

@MSchmoecker
Copy link
Member Author

Of course the second run is faster because a lot is already cached in nix but this still saves a good 2 minutes, from ~14m to ~12m. Especially when a test fails because of code changes, it doesn't have to fail twice because of theming.

The different color screenshots are only to verify the theming and don't affect functionality. So any minute saved here speeds up testing. Especially with the merge queue all CI tests have to run twice, which effectively doubles the whole test duration.

@elikoga
Copy link
Member

elikoga commented Feb 22, 2025

We should probably do a visual walkthrough through the app in light and dark to get Screenshots that doesn't take much time in builds and only test most stuff in one theme, right?

@MSchmoecker
Copy link
Member Author

That would be a possibility, yes

@MSchmoecker MSchmoecker added this pull request to the merge queue Feb 24, 2025
Merged via the queue into master with commit 81ecccd Feb 24, 2025
18 checks passed
@MSchmoecker MSchmoecker deleted the ci/faster-screencaps branch February 24, 2025 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants