Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Already deleted Message returns 404 vs 409 conflict when a 2nd attempt to delete is processed #739

Merged
merged 3 commits into from
Jul 3, 2024

Conversation

LiranCohen
Copy link
Member

After merging #635, which was a bit old, one of the new tests failed upon merge to main.

During a dwn-sdk-js change the return for a conflicting RecordsDelete changed from a 409 to a 404.
https://github.com/TBD54566975/dwn-sdk-js/pull/749/files#diff-169fe156eb9ea99859416850b92e6836907930a425399f2bcb059c9edf4259b6R57

This PR addresses it within the new record.delete() method, as well as for sync, adding additional coverage.

Copy link

changeset-bot bot commented Jul 3, 2024

🦋 Changeset detected

Latest commit: cf212f7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@web5/agent Patch
@web5/identity-agent Patch
@web5/proxy-agent Patch
@web5/user-agent Patch
@web5/api Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jul 3, 2024

TBDocs Report

✅ No errors or warnings

@web5/api

  • Project entry file: packages/api/src/index.ts

@web5/crypto

  • Project entry file: packages/crypto/src/index.ts

@web5/crypto-aws-kms

  • Project entry file: packages/crypto-aws-kms/src/index.ts

@web5/dids

  • Project entry file: packages/dids/src/index.ts

@web5/credentials

  • Project entry file: packages/credentials/src/index.ts

TBDocs Report Updated at 2024-07-03T21:34:26Z cf212f7

@LiranCohen LiranCohen merged commit 5b0c61a into main Jul 3, 2024
13 checks passed
@LiranCohen LiranCohen deleted the lirancohen/fix-failing-test-after-delete-merge branch July 3, 2024 21:42
@github-actions github-actions bot mentioned this pull request Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants