Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated all packages to use ESLint v9 #579

Merged
merged 11 commits into from
May 17, 2024
Merged

Conversation

thehenrytsai
Copy link
Contributor

@thehenrytsai thehenrytsai commented May 16, 2024

Updated all packages to ESLint v9

  1. .eslintrc.cjs name and format are no longer supported, moving to eslint.confg.cjs with the new "flat config" format.
  2. -ext is no longer supported in CLI
  3. Suppressed a bunch of mocha rules for another day: Revisit disabled default mocha rules #580, which will be a massive noise PR touching every tests in this repo.
  4. Fixed every newly surfaced lint errors in every package.

Needless to say, but I'll say it anyway: this was a long painful whack-a-mole exercise.

Copy link

changeset-bot bot commented May 16, 2024

🦋 Changeset detected

Latest commit: ecf1062

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages
Name Type
@web5/api Patch
@web5/common Patch
@web5/crypto Patch
@web5/crypto-aws-kms Patch
@web5/dids Patch
@web5/credentials Patch
@web5/agent Patch
@web5/user-agent Patch
@web5/proxy-agent Patch
@web5/identity-agent Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented May 16, 2024

TBDocs Report

✅ No errors or warnings

@web5/api

  • Project entry file: packages/api/src/index.ts

@web5/crypto

  • Project entry file: packages/crypto/src/index.ts

@web5/crypto-aws-kms

  • Project entry file: packages/crypto-aws-kms/src/index.ts

@web5/dids

  • Project entry file: packages/dids/src/index.ts

@web5/credentials

  • Project entry file: packages/credentials/src/index.ts

TBDocs Report Updated at 2024-05-17T00:41:29Z ecf1062

@codecov-commenter
Copy link

codecov-commenter commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.12%. Comparing base (59a7e60) to head (ecf1062).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #579      +/-   ##
==========================================
- Coverage   91.12%   91.12%   -0.01%     
==========================================
  Files         116      116              
  Lines       29665    29664       -1     
  Branches     2201     2201              
==========================================
- Hits        27033    27032       -1     
  Misses       2597     2597              
  Partials       35       35              
Components Coverage Δ
agent 80.86% <ø> (ø)
api 97.93% <ø> (-0.01%) ⬇️
common 98.68% <ø> (ø)
credentials 95.26% <ø> (ø)
crypto 93.81% <ø> (ø)
dids 97.78% <ø> (ø)
identity-agent 96.70% <ø> (ø)
crypto-aws-kms 100.00% <ø> (ø)
proxy-agent 96.70% <ø> (ø)
user-agent 96.70% <ø> (ø)

Copy link
Member

@LiranCohen LiranCohen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐐 great stuff! Just one thing with the changeset.

Copy link
Contributor

@shamilovtim shamilovtim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets move to biome soon

@thehenrytsai thehenrytsai merged commit b36e7b1 into main May 17, 2024
11 checks passed
@thehenrytsai thehenrytsai deleted the henrytsai/eslint-fiasco branch May 17, 2024 17:08
@github-actions github-actions bot mentioned this pull request May 17, 2024
@github-actions github-actions bot mentioned this pull request May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants