Skip to content

Commit b18651b

Browse files
targosgengjiawen
authored andcommittedOct 19, 2020
build: do not pass mode option to test-v8 command
It was removed upstream and is now inferred from the build config. PR-URL: nodejs#35705 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Rich Trott <[email protected]>
1 parent 84a7880 commit b18651b

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed
 

‎Makefile

+1-2
Original file line numberDiff line numberDiff line change
@@ -668,8 +668,7 @@ test-with-async-hooks:
668668
ifneq ("","$(wildcard deps/v8/tools/run-tests.py)")
669669
# Related CI job: node-test-commit-v8-linux
670670
test-v8: v8 ## Runs the V8 test suite on deps/v8.
671-
deps/v8/tools/run-tests.py --gn --arch=$(V8_ARCH) \
672-
--mode=$(BUILDTYPE_LOWER) $(V8_TEST_OPTIONS) \
671+
deps/v8/tools/run-tests.py --gn --arch=$(V8_ARCH) $(V8_TEST_OPTIONS) \
673672
mjsunit cctest debugger inspector message preparser \
674673
$(TAP_V8)
675674
@echo Testing hash seed

0 commit comments

Comments
 (0)
Please sign in to comment.