Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ui5-shellbar]: wrong accessible name #10970

Closed
1 task done
nnaydenow opened this issue Feb 27, 2025 · 0 comments · Fixed by #11034
Closed
1 task done

[ui5-shellbar]: wrong accessible name #10970

nnaydenow opened this issue Feb 27, 2025 · 0 comments · Fixed by #11034
Assignees
@plamenivanov91
Labels
bug This issue is a bug in the code TOPIC P

Comments

@nnaydenow
Copy link
Contributor

Bug Description

Image

Button with primary title and logo always title adds SAP and home at the descriptive aria label text

Affected Component

ui5-shellbar

Expected Behaviour

To be configured per application. I can't override it if my product is not SAP related, but I want to use the ui5-shellbar

Isolated Example

No response

Steps to Reproduce

...

Log Output, Stack Trace or Screenshots

No response

Priority

None

UI5 Web Components Version

nightly

Browser

Chrome

Operating System

No response

Additional Context

No response

Organization

No response

Declaration

  • I’m not disclosing any internal or sensitive information.
@nnaydenow nnaydenow added bug This issue is a bug in the code TOPIC P labels Feb 27, 2025
@plamenivanov91 plamenivanov91 self-assigned this Feb 28, 2025
@plamenivanov91 plamenivanov91 moved this from Issues to In Progress in Maintenance - Topic P Feb 28, 2025
plamenivanov91 added a commit to plamenivanov91/ui5-webcomponents that referenced this issue Mar 7, 2025
@plamenivanov91
fix(ui5-shellbar): sap home no longer hard coded in title readings
71de440 
Fixes: SAP#10970
@plamenivanov91 plamenivanov91 mentioned this issue Mar 7, 2025
Merged
@github-project-automation github-project-automation bot moved this from In Progress to Completed in Maintenance - Topic P Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@plamenivanov91 plamenivanov91

Labels
bug This issue is a bug in the code TOPIC P
Projects
Maintenance - Topic P
Status: Completed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ui5-shellbar): sap home no longer hard coded in title readings plamenivanov91/ui5-webcomponents
2 participants
@plamenivanov91 @nnaydenow