-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui5-tabcontainer): add noAutoSelection
property
#10877
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One change suggestion, otherwise looks good to me.
Previous comments already addressed
noDefaultSelection
property
noDefaultSelection
propertynoDefaultSelection
property
noDefaultSelection
propertynoAutoSelection
property
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(ui5-tab-container) = (ui5-tabcontainer) ?
They are not the same, made a mistake tought that it is ui5-tab-container, because of the file naming TabContainer. |
noAutoSelection
propertynoAutoSelection
property
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
🎉 This PR is included in version v2.8.0 🎉 The release is available on v2.8.0 Your semantic-release bot 📦🚀 |
A new property
noAutoSelection
is introduced. When enabled, it prevents the automatic selection of the first tab if no tabs haveselected
property set.JIRA: BGSOFUIRODOPI-3416