Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui5-tabcontainer): add noAutoSelection property #10877

Merged
merged 14 commits into from
Mar 4, 2025

Conversation

s-todorova
Copy link
Contributor

@s-todorova s-todorova commented Feb 16, 2025

A new property noAutoSelection is introduced. When enabled, it prevents the automatic selection of the first tab if no tabs have selected property set.

JIRA: BGSOFUIRODOPI-3416

@s-todorova s-todorova requested a review from a team February 17, 2025 12:19
@dimovpetar dimovpetar requested a review from Stoev February 18, 2025 10:02
@s-todorova s-todorova requested a review from a team February 18, 2025 13:26
@s-todorova s-todorova changed the title feat(ui5-tab-container): add NoDefaultSelection property feat(ui5-tabcontainer): add NoDefaultSelection property Feb 18, 2025
Copy link

@Stoev Stoev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One change suggestion, otherwise looks good to me.

@s-todorova s-todorova dismissed dimovpetar’s stale review February 20, 2025 11:00

Previous comments already addressed

@ilhan007 ilhan007 changed the title feat(ui5-tabcontainer): add NoDefaultSelection property feat(ui5-tabcontainer): add noDefaultSelection property Feb 24, 2025
@GerganaKremenska GerganaKremenska changed the title feat(ui5-tabcontainer): add noDefaultSelection property feat(ui5-tab-container): add noDefaultSelection property Feb 26, 2025
@GerganaKremenska GerganaKremenska changed the title feat(ui5-tab-container): add noDefaultSelection property feat(ui5-tab-container): add noAutoSelection property Feb 26, 2025
Copy link

@Stoev Stoev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(ui5-tab-container) = (ui5-tabcontainer) ?

@GerganaKremenska
Copy link
Member

(ui5-tab-container) = (ui5-tabcontainer) ?

They are not the same, made a mistake tought that it is ui5-tab-container, because of the file naming TabContainer.

@GerganaKremenska GerganaKremenska changed the title feat(ui5-tab-container): add noAutoSelection property feat(ui5-tabcontainer): add noAutoSelection property Feb 27, 2025
Copy link

@Stoev Stoev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@GerganaKremenska GerganaKremenska merged commit 581a626 into main Mar 4, 2025
12 checks passed
@ui5-webcomponents-bot
Copy link
Collaborator

🎉 This PR is included in version v2.8.0 🎉

The release is available on v2.8.0

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants