-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ui5-popover): don't close the popover if the opener is clicked #10780
Conversation
…ver_isopenerclicked
…ver_isopenerclicked
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My tentative suggestion is to consider changing the structure of the sentence so to evade the negation. For example:
If the opener is selected, keep the popover open.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
🎉 This PR is included in version v2.8.0-rc.2 🎉 The release is available on v2.8.0-rc.2 Your semantic-release bot 📦🚀 |
Fixes the case when the opener is given by ID.
Fixes #10291