Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui5-popover): don't close the popover if the opener is clicked #10780

Merged
merged 6 commits into from
Feb 17, 2025

Conversation

dimovpetar
Copy link
Contributor

@dimovpetar dimovpetar commented Feb 5, 2025

Fixes the case when the opener is given by ID.

Fixes #10291

Copy link

@Stoev Stoev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My tentative suggestion is to consider changing the structure of the sentence so to evade the negation. For example:

If the opener is selected, keep the popover open.

@dimovpetar dimovpetar requested a review from Stoev February 13, 2025 09:40
Copy link

@Stoev Stoev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@dimovpetar dimovpetar merged commit bc9eb08 into main Feb 17, 2025
12 checks passed
@dimovpetar dimovpetar deleted the fix_popover_isopenerclicked branch February 17, 2025 09:10
@ui5-webcomponents-bot
Copy link
Collaborator

🎉 This PR is included in version v2.8.0-rc.2 🎉

The release is available on v2.8.0-rc.2

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ui5-popover]: can't close opened popover by clicking the opener
4 participants