Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui5-menu]: line-height set to body should not influence menu items #10754

Closed
1 task done
MapTo0 opened this issue Feb 3, 2025 · 2 comments · Fixed by #10916
Closed
1 task done

[ui5-menu]: line-height set to body should not influence menu items #10754

MapTo0 opened this issue Feb 3, 2025 · 2 comments · Fixed by #10916
Assignees
Labels
bug This issue is a bug in the code Medium Prio released TOPIC B

Comments

@MapTo0
Copy link
Member

MapTo0 commented Feb 3, 2025

Bug Description

Hello colleagues,

Adding a style for the line-height to the body of the page breaks the visualisation of the ui5-menu-item component

Affected Component

No response

Expected Behaviour

line-height is applied directly to elements and can only be changed if explicitly set on the component itself. It does not take effect when inherited from the body.

Isolated Example

https://sap.github.io/ui5-webcomponents/play/#eyJpbmRleC5odG1sIjp7Im5hbWUiOiJpbmRleC5odG1sIiwiY29udGVudCI6IjwhLS0gcGxheWdyb3VuZC1mb2xkIC0tPlxuPCFET0NUWVBFIGh0bWw-XG48aHRtbCBsYW5nPVwiZW5cIj5cblxuXG5cbjxoZWFkPlxuICAgIFxuICAgIDxzdHlsZT5cbiAgICAgICo6bm90KDpkZWZpbmVkKSB7XG4gICAgICAgIGRpc3BsYXk6IG5vbmU7XG4gICAgICB9XG5cbiAgICBodG1sIHtcbiAgICAgIGZvcmNlZC1jb2xvci1hZGp1c3Q6IG5vbmU7XG4gICAgfVxuICAgIDwvc3R5bGU-XG5cbiAgICBcbiAgICA8c3R5bGU-XG4gICAgICAqOm5vdCg6ZGVmaW5lZCkge1xuICAgICAgICBkaXNwbGF5OiBub25lO1xuICAgICAgfVxuXG4gICAgaHRtbCB7XG4gICAgICBmb3JjZWQtY29sb3ItYWRqdXN0OiBub25lO1xuICAgIH1cbiAgICA8L3N0eWxlPlxuXG4gICAgPG1ldGEgY2hhcnNldD1cIlVURi04XCI-XG4gICAgPG1ldGEgbmFtZT1cInZpZXdwb3J0XCIgY29udGVudD1cIndpZHRoPWRldmljZS13aWR0aCwgaW5pdGlhbC1zY2FsZT0xLjBcIj5cbiAgICA8dGl0bGU-U2FtcGxlPC90aXRsZT5cbjwvaGVhZD5cblxuPGJvZHkgc3R5bGU9XCJiYWNrZ3JvdW5kLWNvbG9yOiB2YXIoLS1zYXBCYWNrZ3JvdW5kQ29sb3IpOyBoZWlnaHQ6IDM1MHB4XCI-XG4gICAgPCEtLSBwbGF5Z3JvdW5kLWZvbGQtZW5kIC0tPlxuXG4gICAgPHVpNS1idXR0b24gaWQ9XCJidG5PcGVuQmFzaWNcIiBlbmQtaWNvbj1cInNsaW0tYXJyb3ctZG93blwiPk9wZW4gTWVudTwvdWk1LWJ1dHRvbj4gPGJyPlxuXG4gICAgPHVpNS1tZW51IGhlYWRlci10ZXh0PVwiQmFzaWMgTWVudSB3aXRoIEl0ZW1zXCIgaWQ9XCJtZW51QmFzaWNcIiBvcGVuZXI9XCJidG5PcGVuQmFzaWNcIj5cbiAgICAgICAgPHVpNS1tZW51LWl0ZW0gdGV4dD1cIk5ldyBGaWxlXCIgaWNvbj1cImFkZC1kb2N1bWVudFwiPjwvdWk1LW1lbnUtaXRlbT5cbiAgICAgICAgPHVpNS1tZW51LWl0ZW0gdGV4dD1cIk5ldyBGb2xkZXJcIiBpY29uPVwiYWRkLWZvbGRlclwiIGRpc2FibGVkPjwvdWk1LW1lbnUtaXRlbT5cbiAgICAgICAgPHVpNS1tZW51LXNlcGFyYXRvcj48L3VpNS1tZW51LXNlcGFyYXRvcj5cbiAgICAgICAgPHVpNS1tZW51LWl0ZW0gdGV4dD1cIk9wZW5cIiBpY29uPVwib3Blbi1mb2xkZXJcIj48L3VpNS1tZW51LWl0ZW0-XG4gICAgICAgIDx1aTUtbWVudS1pdGVtIHRleHQ9XCJDbG9zZVwiPjwvdWk1LW1lbnUtaXRlbT5cbiAgICAgICAgPHVpNS1tZW51LXNlcGFyYXRvcj48L3VpNS1tZW51LXNlcGFyYXRvcj5cbiAgICAgICAgPHVpNS1tZW51LWl0ZW0gdGV4dD1cIlByZWZlcmVuY2VzXCIgaWNvbj1cImFjdGlvbi1zZXR0aW5nc1wiPjwvdWk1LW1lbnUtaXRlbT5cbiAgICAgICAgPHVpNS1tZW51LWl0ZW0gdGV4dD1cIkV4aXRcIiBpY29uPVwiam91cm5leS1hcnJpdmVcIj48L3VpNS1tZW51LWl0ZW0-XG4gICAgPC91aTUtbWVudT5cbiAgXG4gIDxzdHlsZT5cbiAgICBib2R5IHtcbiAgICAgIGxpbmUtaGVpZ2h0OiAuNXJlbTtcbiAgICB9XG4gIDwvc3R5bGU-XG4gICAgPCEtLSBwbGF5Z3JvdW5kLWZvbGQgLS0-XG4gICAgPHNjcmlwdCB0eXBlPVwibW9kdWxlXCIgc3JjPVwibWFpbi5qc1wiPjwvc2NyaXB0PlxuPC9ib2R5PlxuXG48L2h0bWw-XG48IS0tIHBsYXlncm91bmQtZm9sZC1lbmQgLS0-XG4ifSwibWFpbi5qcyI6eyJuYW1lIjoibWFpbi5qcyIsImNvbnRlbnQiOiIvKiBwbGF5Z3JvdW5kLWhpZGUgKi9cbmltcG9ydCBcIi4vcGxheWdyb3VuZC1zdXBwb3J0LmpzXCI7XG4vKiBwbGF5Z3JvdW5kLWhpZGUtZW5kICovXG5pbXBvcnQgXCJAdWk1L3dlYmNvbXBvbmVudHMvZGlzdC9NZW51LmpzXCI7XG5pbXBvcnQgXCJAdWk1L3dlYmNvbXBvbmVudHMvZGlzdC9NZW51SXRlbS5qc1wiO1xuaW1wb3J0IFwiQHVpNS93ZWJjb21wb25lbnRzL2Rpc3QvTWVudVNlcGFyYXRvci5qc1wiO1xuXG5pbXBvcnQgXCJAdWk1L3dlYmNvbXBvbmVudHMtaWNvbnMvZGlzdC9hZGQtZG9jdW1lbnQuanNcIjtcbmltcG9ydCBcIkB1aTUvd2ViY29tcG9uZW50cy1pY29ucy9kaXN0L2FkZC1mb2xkZXIuanNcIjtcbmltcG9ydCBcIkB1aTUvd2ViY29tcG9uZW50cy1pY29ucy9kaXN0L29wZW4tZm9sZGVyLmpzXCI7XG5pbXBvcnQgXCJAdWk1L3dlYmNvbXBvbmVudHMtaWNvbnMvZGlzdC9zYXZlLmpzXCI7XG5pbXBvcnQgXCJAdWk1L3dlYmNvbXBvbmVudHMtaWNvbnMvZGlzdC91cGxvYWQtdG8tY2xvdWQuanNcIjtcbmltcG9ydCBcIkB1aTUvd2ViY29tcG9uZW50cy1pY29ucy9kaXN0L2FjdGlvbi1zZXR0aW5ncy5qc1wiO1xuaW1wb3J0IFwiQHVpNS93ZWJjb21wb25lbnRzLWljb25zL2Rpc3Qvam91cm5leS1hcnJpdmUuanNcIjtcbmltcG9ydCBcIkB1aTUvd2ViY29tcG9uZW50cy1pY29ucy9kaXN0L3NsaW0tYXJyb3ctZG93bi5qc1wiO1xuXG5jb25zdCBidG5PcGVuQmFzaWMgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZChcImJ0bk9wZW5CYXNpY1wiKTtcbmNvbnN0IG1lbnVCYXNpYyA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKFwibWVudUJhc2ljXCIpO1xuXG5idG5PcGVuQmFzaWMuYWRkRXZlbnRMaXN0ZW5lcihcImNsaWNrXCIsIGZ1bmN0aW9uKGV2ZW50KSB7XG4gICAgbWVudUJhc2ljLm9wZW4gPSAhbWVudUJhc2ljLm9wZW47XG59KTsifX0

Steps to Reproduce

No response

Log Output, Stack Trace or Screenshots

No response

Priority

None

UI5 Web Components Version

latest

Browser

Chrome, Edge, Firefox, Safari

Operating System

No response

Additional Context

No response

Organization

No response

Declaration

  • I’m not disclosing any internal or sensitive information.
@MapTo0 MapTo0 added the bug This issue is a bug in the code label Feb 3, 2025
@NHristov-sap
Copy link
Contributor

Hello @SAP/ui5-webcomponents-topic-b,

I am forwarding this Menu issue to you, please check and fix.

Best Regards,
Nikolay Hristov

@hinzzx hinzzx self-assigned this Feb 20, 2025
@hinzzx hinzzx moved this from New Issues to In Progress in Maintenance - Topic B Feb 20, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Completed in Maintenance - Topic B Feb 20, 2025
@ui5-webcomponents-bot
Copy link
Collaborator

🎉 This issue has been resolved in version v2.8.0-rc.3 🎉

The release is available on v2.8.0-rc.3

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug in the code Medium Prio released TOPIC B
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

4 participants