fix(ui5-flexible-column-layout): adjust grip minimum target size #10743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure if it's an issue, but the new "grip area" is now invisible horizontally, and overlaps the content, but vertically it pushes the graphical elements a few pixels up and down: 
But maybe it's the intended design. Just double-check please |
plamenivanov91
approved these changes
Feb 4, 2025
|
🎉 This PR is included in version v2.8.0-rc.0 🎉 The release is available on v2.8.0-rc.0 Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
The grip did not meet the minimum target size requirements.
Solution:
Add a container div around the grip icon to control the minimum target size, setting it to 1.5rem width and 2rem height.
Explanation:
Restructured the grip to handle width and height at the div level instead of the icon because the .ui5-icon-root class (which gets automatically applied to icons) sets width and height to 100%. Applying the dimensions directly to the icon would cause it to stretch and fill the entire available space, distorting its proportions.
Fixes: #10669