-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(AnalyticalTable - TypeScript): correct typing for onRowClick
and accessor function
#6520
Conversation
Pull Request Test Coverage Report for Build 11503651671Details
💛 - Coveralls |
I fount the type for
is also incorrect,
because in if (column.accessor) {
row.values[column.id] = column.accessor(originalRow, rowIndex, row, parentRows, data);
} // Allow plugins to manipulate the column value |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Jianrong-Yu thanks a lot for your contribution!
onRowClick
and accessor function
…e the types of accessor and onRowClick Co-authored-by: Lukas Harbarth <[email protected]>
@Lukas742 Thanks for you suggestions, the code is modified now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚢
Thanks again for your contribution!
🎉 This PR is included in version v2.3.3 🎉 The release is available on v2.3.3 Your semantic-release bot 📦🚀 |
Fix #6519
Based on the code in
packages/main/src/components/AnalyticalTable/hooks/useSingleRowStateSelection.ts
, the type ofOnRowClickEvent
should beAnd the type
MouseEvent
should be changed toUIEvent
since the event can also be a Keyboard event based on the code: