-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(DynamicPage & ObjectPage): use ui5wc DynamicPage
& rename ObjectPage
components
#5939
Merged
+1,335
−2,054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: -3.06 kB (-0.76%) Total Size: 401 kB
ℹ️ View Unchanged
|
Pull Request Test Coverage Report for Build 9561743699Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9562868000Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9566331569Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9566453555Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9566543281Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9566708090Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9568247975Details
💛 - Coveralls |
packages/main/src/webComponents/DynamicPage/DynamicPage.stories.tsx
Outdated
Show resolved
Hide resolved
…s.tsx Co-authored-by: Marcus Notheis <[email protected]>
Pull Request Test Coverage Report for Build 9577316547Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9579687662Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9581640895Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9581694572Details
💛 - Coveralls |
MarcusNotheis
approved these changes
Jun 20, 2024
Pull Request Test Coverage Report for Build 9596692451Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
🎉 This PR is included in version v2.0.0-rc.0 🎉 The release is available on v2.0.0-rc.0 Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: The
DynamicPage
component has been replaced with theui5-dynamic-page
UI5 Web Component, please visit our Migration Guide for more details.BREAKING CHANGE: The
DynamicPageHeader
component has been replaced with theui5-dynamic-page-header
UI5 Web Component, please visit our Migration Guide for more details.BREAKING CHANGE: The
DynamicPageTitle
component has been replaced with theui5-dynamic-page-title
UI5 Web Component, please visit our Migration Guide for more details.BREAKING CHANGE: ObjectPage:
headerTitle
now only accepts theObjectPageTitle
component instead of theDynamicPageTitle
.BREAKING CHANGE: ObjectPage:
headerContent
now only accepts theObjectPageHeader
component instead of theDynamicPageTitle
.BREAKING CHANGE: ObjectPage:
a11yConfig.dynamicPageAnchorBar
has been renamed toa11yConfig.objectPageAnchorBar