Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting fee sats/vbyte for closing channel miscalculates actual fee rate #1345

Open
abinition opened this issue Jan 17, 2024 · 3 comments
Open

Comments

@abinition
Copy link

Upon closing a channel, (I) selected 50 sats/vbyte, but when transaction was viewed on mempool, it showed 24.4 sats/vbyte. Afterwards, tried doing a "force close" which added a CPFP, this increased fee rate to 47.5 sats/vbyte. Hope it confirms.

Devs should check the math calculation for channel close and apply the correct fee amount from what is selected on web interface.

Hard to reproduce without opening and then closing channels, which costs $$.

Original transaction is ec14e99da2e158bd6aacb4b74292fec1e663453108e5d5d5b9495bacdfd94d88

@saubyk
Copy link
Collaborator

saubyk commented Jan 18, 2024

Hi @abinition RTL just passes the value user provides in the UI to the API.

Was it a cooperative close or a force close when you first attempted?

@anafaskrowten
Copy link

Hi @abinition RTL just passes the value user provides in the UI to the API.

Was it a cooperative close or a force close when you first attempted?

Is this feature in RTL only for LND nodes? I'm running both LND and CLN and both using RTL 0.15.4-beta and the CLN one does not have any place to collect a fee rate.

@saubyk
Copy link
Collaborator

saubyk commented Feb 14, 2025

CLN one does not have any place to collect a fee rate

Needs further investigation as to why this decision was made. cc: @ShahanaFarooqui

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants