Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add annotation #33

Merged
merged 1 commit into from
Dec 15, 2022
Merged

Add annotation #33

merged 1 commit into from
Dec 15, 2022

Conversation

trungleduc
Copy link
Member

@trungleduc trungleduc commented Nov 30, 2022 •
edited
Loading

qqjRH1UeWx.mp4

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch trungleduc/jupytercad/annotation

@trungleduc trungleduc force-pushed the annotation branch 2 times, most recently from e15d373 to 1624de0 Compare December 5, 2022 02:34
@martinRenou martinRenou force-pushed the main branch 2 times, most recently from ee39119 to 7586479 Compare December 6, 2022 12:34
@trungleduc trungleduc force-pushed the annotation branch 3 times, most recently from 7a3343a to 392a578 Compare December 12, 2022 17:22
@trungleduc trungleduc marked this pull request as ready for review December 13, 2022 14:25
martinRenou
martinRenou reviewed Dec 14, 2022
View reviewed changes
style/base.css
}

.jcad-Annotation-Submit g {
fill: #f6f7f8 !important;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably use lab CSS variables in this file

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't use the CSS variable because the annotation dialog does not have the dark/light theme yet. We might add the theme support in a follow-up PR.

martinRenou
martinRenou approved these changes Dec 15, 2022
View reviewed changes
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@martinRenou martinRenou merged commit 5177e0d into jupytercad:main Dec 15, 2022
@trungleduc trungleduc deleted the annotation branch May 7, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinRenou martinRenou martinRenou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trungleduc @martinRenou