Remove gradient background #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Hey please update snapshots again |
Merged
martinRenou
force-pushed
the
remove_gradient_background
branch
from
8dee710 to
518d02d
Compare
trungleduc
reviewed
May 25, 2023
Comment on lines
42
to
43
| const DARK_BG_COLOR = 'linear-gradient(rgb(0, 0, 42), rgb(82, 87, 110))'; | ||
| const LIGHT_BG_COLOR = 'radial-gradient(#efeded, #8f9091)'; | ||
|
|
||
| const DEFAULT_MESH_COLOR = new THREE.Color('#434442'); | ||
| const SELECTED_MESH_COLOR = new THREE.Color('#AB5118'); |
There was a problem hiding this comment.
Could we make the mesh color a little bit brighter?
There was a problem hiding this comment.
Yes I'm working on it 👍🏽
martinRenou
force-pushed
the
remove_gradient_background
branch
from
518d02d to
cba4898
Compare
martinRenou
commented
May 25, 2023
Comment on lines
42
to
44
| const DEFAULT_MESH_COLOR = () => new THREE.Color(getCSSVariableColor('--jp-inverse-layout-color4')); | ||
| const DEFAULT_EDGE_COLOR = () => new THREE.Color(getCSSVariableColor('--jp-inverse-layout-color2')); | ||
| const SELECTED_MESH_COLOR = () => new THREE.Color(getCSSVariableColor('--jp-brand-color0')); |
There was a problem hiding this comment.
Not sure about these, it's probably too expensive to evaluate everytime we need colors. I'll change it to evaluate only when the theme changes.
|
@trungleduc this is ready! |
trungleduc
approved these changes
May 25, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.