-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes selections #103
Fixes selections #103
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice refactoring 👍🏽
@@ -8,6 +8,7 @@ jupytercad/labextension | |||
|
|||
# Created by https://www.gitignore.io/api/python | |||
# Edit at https://www.gitignore.io/?templates=python | |||
jupytercad/_version.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the reason for adding this to gitignore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose it's related to the hatch migration?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I posted a comment here.
Thanks @hbcarlos |
I see a bit of latency in zooming/panning introduced by this PR. I'm having a look. |
Fixes #95
Grabacion.de.pantalla.2023-01-21.a.las.18.30.34.mov