Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes selections #103

Merged
merged 2 commits into from
Jan 23, 2023
Merged

Fixes selections #103

merged 2 commits into from
Jan 23, 2023

Conversation

hbcarlos
Copy link
Contributor

Fixes #95

Grabacion.de.pantalla.2023-01-21.a.las.18.30.34.mov

@hbcarlos hbcarlos added the bug label Jan 21, 2023
@hbcarlos hbcarlos requested a review from trungleduc January 21, 2023 17:40
@hbcarlos hbcarlos self-assigned this Jan 21, 2023
@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch hbcarlos/jupytercad/fix_95

@hbcarlos hbcarlos marked this pull request as draft January 21, 2023 18:22
@hbcarlos hbcarlos marked this pull request as ready for review January 22, 2023 10:46
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactoring 👍🏽

@@ -8,6 +8,7 @@ jupytercad/labextension

# Created by https://www.gitignore.io/api/python
# Edit at https://www.gitignore.io/?templates=python
jupytercad/_version.py
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reason for adding this to gitignore?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose it's related to the hatch migration?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I posted a comment here.

@trungleduc
Copy link
Member

Thanks @hbcarlos

@trungleduc trungleduc merged commit cfe2b88 into jupytercad:main Jan 23, 2023
@hbcarlos hbcarlos deleted the fix_95 branch January 23, 2023 10:10
@martinRenou
Copy link
Member

I see a bit of latency in zooming/panning introduced by this PR. I'm having a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Selection from the tree view seems broken now?
3 participants