Refactor the find_all_configs function

Author: anirudnits

isort/settings.py

@@ -787,28 +787,32 @@ def _find_config(path: str) -> Tuple[str, Dict[str, Any]]:
 
 
 @lru_cache()
-def find_all_configs(src_paths: Tuple[str]) -> Trie:
-    trie_root = Trie("default", DEFAULT_CONFIG.__dict__)
-
-    for path in src_paths:
-        for (dirpath, _, _) in os.walk(path):
-            for config_file_name in CONFIG_SOURCES:
-                potential_config_file = os.path.join(dirpath, config_file_name)
-                if os.path.isfile(potential_config_file):
-                    config_data: Dict[str, Any]
-                    try:
-                        config_data = _get_config_data(
-                            potential_config_file, CONFIG_SECTIONS[config_file_name]
-                        )
-                    except Exception:
-                        warn(
-                            f"Failed to pull configuration information from {potential_config_file}"
-                        )
-                        config_data = {}
+def find_all_configs(path: str) -> Trie:
+    """
+    Looks for config files in the path provided and in all of its sub-directories.
+    Parses and stores any config file encountered in a trie and returns the root of
+    the trie
+    """
+    trie_root = Trie("default", {})
 
-                    if config_data:
-                        trie_root.insert(potential_config_file, config_data)
-                        break
+    for (dirpath, _, _) in os.walk(path):
+        for config_file_name in CONFIG_SOURCES:
+            potential_config_file = os.path.join(dirpath, config_file_name)
+            if os.path.isfile(potential_config_file):
+                config_data: Dict[str, Any]
+                try:
+                    config_data = _get_config_data(
+                        potential_config_file, CONFIG_SECTIONS[config_file_name]
+                    )
+                except Exception:
+                    warn(
+                        f"Failed to pull configuration information from {potential_config_file}"
+                    )
+                    config_data = {}
+
+                if config_data:
+                    trie_root.insert(potential_config_file, config_data)
+                    break
 
     return trie_root