remove vcs integration

Author: asottile

docs/source/internal/writing-code.rst

@@ -59,7 +59,6 @@ accepts as well as what it returns.
             filepaths = list(copy_indexed_files_to(tempdir, lazy))
             app.initialize(['.'])
             app.options.exclude = update_excludes(app.options.exclude, tempdir)
-            app.options._running_from_vcs = True
             app.run_checks(filepaths)
 
         app.report_errors()

docs/source/manpage.rst

@@ -70,9 +70,6 @@ All options available as of Flake8 3.1.0::
                           Enable plugins and extensions that are otherwise
                           disabled by default
     --exit-zero           Exit with status code "0" even if there are errors.
-    --install-hook=INSTALL_HOOK
-                          Install a hook that is run prior to a commit for the
-                          supported version control system.
     -j JOBS, --jobs=JOBS  Number of subprocesses to use to run checks in
                           parallel. This is ignored on Windows. The default,
                           "auto", will auto-detect the number of processors

docs/source/user/options.rst

@@ -78,8 +78,6 @@ Index of Options
 
 - :option:`flake8 --exit-zero`
 
-- :option:`flake8 --install-hook`
-
 - :option:`flake8 --jobs`
 
 - :option:`flake8 --output-file`
@@ -751,28 +749,6 @@ Options and their Descriptions
     This **can not** be specified in config files.
 
 
-.. option:: --install-hook=VERSION_CONTROL_SYSTEM
-
-    :ref:`Go back to index <top>`
-
-    Install a hook for your version control system that is executed before
-    or during commit.
-
-    The available options are:
-
-    - git
-    - mercurial
-
-    Command-line usage:
-
-    .. prompt:: bash
-
-        flake8 --install-hook=git
-        flake8 --install-hook=mercurial
-
-    This **can not** be specified in config files.
-
-
 .. option:: --jobs=<n>
 
     :ref:`Go back to index <top>`

docs/source/user/using-hooks.rst

@@ -36,83 +36,7 @@ plugins, use the ``additional_dependencies`` setting.
         -   id: flake8
             additional_dependencies: [flake8-docstrings]
 
-
-Built-in Hook Integration
-=========================
-
-.. note::
-
-    It is strongly suggested to use |Flake8| via `pre-commit`_ over the
-    built-in hook mechanisms.  ``pre-commit`` smooths out many of the rough
-    edges of ``git`` and is much more battle-tested than the |Flake8|
-    hook implementation.
-
-|Flake8| can be integrated into your development workflow in many ways. A
-default installation of |Flake8| can install pre-commit hooks for both
-`Git`_ and `Mercurial`_. To install a built-in hook, you can use the
-:option:`flake8 --install-hook` command-line option. For example, you can
-install a git pre-commit hook by running:
-
-.. prompt:: bash
-
-    flake8 --install-hook git
-
-This will install the pre-commit hook into ``.git/hooks/``. Alternatively,
-you can install the mercurial commit hook by running
-
-.. prompt:: bash
-
-    flake8 --install-hook mercurial
-
-
-Preventing Commits
-==================
-
-By default, |Flake8| does not prevent you from creating a commit with these
-hooks. Both hooks can be configured to be strict easily.
-
-Both our Git and Mercurial hooks check for the presence of ``flake8.strict``
-in each VCS' config. For example, you might configure this like so:
-
-.. prompt:: bash
-
-    git config --bool flake8.strict true
-    hg config flake8.strict true
-
-
-Checking All Modified Files Currently Tracked
-=============================================
-
-.. note::
-
-    Mercurial does not have the concept of an index or "stage" as best as I
-    understand.
-
-|Flake8| aims to make smart choices that keep things fast for users where
-possible. As a result, the |Flake8| Git pre-commit will default to only
-checking files that have been staged (i.e., added to the index). If, however,
-you are keen to be lazy and not independently add files to your git index, you
-can set ``flake8.lazy`` to ``true`` (similar to how you would set
-``flake8.strict`` above) and this will check all tracked files.
-
-This is to support users who often find themselves doing things like:
-
-.. prompt:: bash
-
-    git commit -a
-
-.. note::
-
-    If you have files you have not yet added to the index, |Flake8| will not
-    see these and will not check them for you. You must ``git-add`` them
-    first.
-
-
 .. _pre-commit:
     https://pre-commit.com/
 .. _pre-commit docs:
     https://pre-commit.com/#pre-commit-configyaml---hooks
-.. _Git:
-    https://git-scm.com/
-.. _Mercurial:
-    https://www.mercurial-scm.org/

src/flake8/checker.py

@@ -200,7 +200,6 @@ def make_checkers(self, paths=None):
             paths = ["."]
 
         filename_patterns = self.options.filename
-        running_from_vcs = self.options._running_from_vcs
         running_from_diff = self.options.diff
 
         # NOTE(sigmavirus24): Yes this is a little unsightly, but it's our
@@ -218,10 +217,8 @@ def should_create_file_checker(filename, argument):
             # the event that the argument and the filename are identical.
             # If it was specified explicitly, the user intended for it to be
             # checked.
-            explicitly_provided = (
-                not running_from_vcs
-                and not running_from_diff
-                and (argument == filename)
+            explicitly_provided = not running_from_diff and (
+                argument == filename
             )
             return (
                 explicitly_provided or matches_filename_patterns

src/flake8/exceptions.py

@@ -93,51 +93,3 @@ def __str__(self):  # type: () -> str
             "name": self.plugin["plugin_name"],
             "exc": self.original_exception,
         }
-
-
-class HookInstallationError(Flake8Exception):
-    """Parent exception for all hooks errors."""
-
-
-class GitHookAlreadyExists(HookInstallationError):
-    """Exception raised when the git pre-commit hook file already exists."""
-
-    def __init__(self, path):  # type: (str) -> None
-        """Initialize the exception message from the `path`."""
-        self.path = path
-        tmpl = (
-            "The Git pre-commit hook ({0}) already exists. To convince "
-            "Flake8 to install the hook, please remove the existing "
-            "hook."
-        )
-        super(GitHookAlreadyExists, self).__init__(tmpl.format(self.path))
-
-
-class MercurialHookAlreadyExists(HookInstallationError):
-    """Exception raised when a mercurial hook is already configured."""
-
-    hook_name = None  # type: str
-
-    def __init__(self, path, value):  # type: (str, str) -> None
-        """Initialize the relevant attributes."""
-        self.path = path
-        self.value = value
-        tmpl = (
-            'The Mercurial {0} hook already exists with "{1}" in {2}. '
-            "To convince Flake8 to install the hook, please remove the "
-            "{0} configuration from the [hooks] section of your hgrc."
-        )
-        msg = tmpl.format(self.hook_name, self.value, self.path)
-        super(MercurialHookAlreadyExists, self).__init__(msg)
-
-
-class MercurialCommitHookAlreadyExists(MercurialHookAlreadyExists):
-    """Exception raised when the hg commit hook is already configured."""
-
-    hook_name = "commit"
-
-
-class MercurialQRefreshHookAlreadyExists(MercurialHookAlreadyExists):
-    """Exception raised when the hg commit hook is already configured."""
-
-    hook_name = "qrefresh"

src/flake8/main/application.py

@@ -191,8 +191,6 @@ def parse_configuration_and_cli(
             if not self.parsed_diff:
                 self.exit()
 
-        self.options._running_from_vcs = False
-
         self.check_plugins.provide_options(
             self.option_manager, self.options, self.args
         )

src/flake8/main/git.py

@@ -4,7 +4,6 @@
 
 from flake8 import defaults
 from flake8.main import debug
-from flake8.main import vcs
 
 
 def register_preliminary_options(parser):
@@ -322,14 +321,6 @@ def register_default_options(option_manager):
         help='Exit with status code "0" even if there are errors.',
     )
 
-    add_option(
-        "--install-hook",
-        action=vcs.InstallAction,
-        choices=vcs.choices(),
-        help="Install a hook that is run prior to a commit for the supported "
-        "version control system.",
-    )
-
     add_option(
         "-j",
         "--jobs",

src/flake8/main/mercurial.py

@@ -2,13 +2,6 @@
 # -*- coding: utf-8 -*-
 from __future__ import absolute_import
 
-try:
-    # The 'demandimport' breaks pyflakes and flake8.plugins.pyflakes
-    from mercurial import demandimport
-except ImportError:
-    pass
-else:
-    demandimport.disable()
 import os
 from typing import List