Markup: Fixed quotes in HTML attribute values (#3442)

RunDevelopment · web-flow · commit ca8eaeeec47d · 2022-04-29T12:13:01.000+02:00
diff --git a/components/prism-markup.js b/components/prism-markup.js
@@ -51,7 +51,10 @@ Prism.languages.markup = {
 							pattern: /^=/,
 							alias: 'attr-equals'
 						},
-						/"|'/
+						{
+							pattern: /^(\s*)["']|["']$/,
+							lookbehind: true
+						}
 					]
 				}
 			},
diff --git a/components/prism-markup.min.js b/components/prism-markup.min.js
diff --git a/prism.js b/prism.js
@@ -1325,7 +1325,10 @@ Prism.languages.markup = {
 							pattern: /^=/,
 							alias: 'attr-equals'
 						},
-						/"|'/
+						{
+							pattern: /^(\s*)["']|["']$/,
+							lookbehind: true
+						}
 					]
 				}
 			},
diff --git a/tests/languages/markup!+javascript/javascript_inclusion.test b/tests/languages/markup!+javascript/javascript_inclusion.test
@@ -143,10 +143,7 @@ let foo = '</script>';
 		["attr-value", [
 			["punctuation", "="],
 			["punctuation", "\""],
-			"this.textContent=",
-			["punctuation", "'"],
-			"Over!",
-			["punctuation", "'"],
+			"this.textContent='Over!'",
 			["punctuation", "\""]
 		]],
 		["punctuation", ">"]
diff --git a/tests/languages/markup/issue3441.test b/tests/languages/markup/issue3441.test
@@ -0,0 +1,27 @@
+<google-chart data='[["Month", "Days"], ["Jan", 31]]'></google-chart>
+
+----------------------------------------------------
+
+[
+	["tag", [
+		["tag", [
+			["punctuation", "<"],
+			"google-chart"
+		]],
+		["attr-name", ["data"]],
+		["attr-value", [
+			["punctuation", "="],
+			["punctuation", "'"],
+			"[[\"Month\", \"Days\"], [\"Jan\", 31]]",
+			["punctuation", "'"]
+		]],
+		["punctuation", ">"]
+	]],
+	["tag", [
+		["tag", [
+			["punctuation", "</"],
+			"google-chart"
+		]],
+		["punctuation", ">"]
+	]]
+]

Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,10 @@ Prism.languages.markup = {`
`51`	`51`	`pattern: /^=/,`
`52`	`52`	`alias: 'attr-equals'`
`53`	`53`	`},`
`54`		`- /"\|'/`
	`54`	`+ {`
	`55`	`+ pattern: /^(\s*)["']\|["']$/,`
	`56`	`+ lookbehind: true`
	`57`	`+ }`
`55`	`58`	`]`
`56`	`59`	`}`
`57`	`60`	`},`
Original file line number	Diff line number	Diff line change
`@@ -1325,7 +1325,10 @@ Prism.languages.markup = {`
`1325`	`1325`	`pattern: /^=/,`
`1326`	`1326`	`alias: 'attr-equals'`
`1327`	`1327`	`},`
`1328`		`- /"\|'/`
	`1328`	`+ {`
	`1329`	`+ pattern: /^(\s*)["']\|["']$/,`
	`1330`	`+ lookbehind: true`
	`1331`	`+ }`
`1329`	`1332`	`]`
`1330`	`1333`	`}`
`1331`	`1334`	`},`