-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pip defaults to older tabpfn
version when you have python3.13.
#234
Comments
I am curious as to why there is an upper bound on the python version. If the user is using prerelease version of python, it is their responsibility since the python version is not stable yet. The only problem that I could see is with third party libraries not supporting stable and very new python version (or not providing wheels for it). In this case, it is kind of responsibility of user to deal with the installation of pytorch, which is ok since they can't install pytorch to begin with. This is also standard convention across many python libraries I have seen. Pytorch, numpy all use no upper bound on python version. Regarding past library versions, one can introduce a new minor-minor version (e.g. 2.0.1 -> 2.0.1.1) (with the current python requirements) to the past version so hopefully this minor version will be picked up by their package manager. I have not seen this trick being used, but as far as pep standards go see here this is valid. |
Thanks @mert-kurttutan, these are great points! It's true that we could get rid of the max python version altogether. |
For now I've yanked the older
|
That type control is needed only if the other packages exhibit very weird error on their semver rules, which I dont have the emprical evidence of, or python does not obey semver rules, which again is not possible. I guess we disagree on this point, Why not just release new minor version on python 3.13? Right after pytorch release? They seem pretty good as far as semver goes. So transition 3.12->3.13 seems easy in theory. For instance 3.13 is the default version that installs in the current venv managers, e.g. uv
That kind of friction for new users seems important. Some might not even know what is wrong and not report and work with some other tool that works on default python version, which is 3.13 in some venv managers. |
Yes once we release a new version which supports python3.13 we have no problem, the question is what to do for new python versions while we don't support them yet. It's possible I haven't understood the solution you're suggesting though. |
My suggestion is to release the new version for 3.13 as soon as that python version (+new torch release for that python version) is out. |
#240 will add python3.13 support, and remove the max python version. |
Our current version doesn't support python3.13, but this was not specified for past tabpfn versions (though they probably don't support it either), so pip default to installing these older versions if you have python3.13 instead of saying that we don't support python3.13. This creates hard to understand issues like #203 where people don't realize they have an older
tabpfn
versionSolutions:
pip install tabpfn<2
)The text was updated successfully, but these errors were encountered: