Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code cleaning: Style argument needed ? #188

Open
mert-kurttutan opened this issue Feb 17, 2025 · 1 comment
Open

Code cleaning: Style argument needed ? #188

mert-kurttutan opened this issue Feb 17, 2025 · 1 comment

Comments

@mert-kurttutan
Copy link
Contributor

mert-kurttutan commented Feb 17, 2025

Seems like style argument is not used in transformer models.
Is this true?
You can check code with style argument removed from (internal) transfomer model: https://github.com/mert-kurttutan/TabPFN/tree/style-argument

It passes all the tests.

@LeoGrin
Copy link
Collaborator

LeoGrin commented Feb 19, 2025

Thanks @mert-kurttutan ! It is indeed unused in the current implementation IIRC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants