Skip to content

Commit 845b30c

Browse files
committed
Deprecate bugReporting.project setting
This setting was never meant to be changed!
1 parent 942a201 commit 845b30c

File tree

4 files changed

+5
-8
lines changed

4 files changed

+5
-8
lines changed

package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -641,7 +641,8 @@
641641
"powershell.bugReporting.project": {
642642
"type": "string",
643643
"default": "https://github.com/PowerShell/vscode-powershell",
644-
"description": "Specifies the URL of the GitHub project in which to generate bug reports."
644+
"description": "Specifies the URL of the GitHub project in which to generate bug reports.",
645+
"deprecationMessage": "This setting was never meant to be changed!"
645646
},
646647
"powershell.helpCompletion": {
647648
"type": "string",

src/features/GenerateBugReport.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,10 @@ import os = require("os");
55
import vscode = require("vscode");
66
import child_process = require("child_process");
77
import { SessionManager } from "../session";
8-
import { getSettings } from "../settings";
98

109
const queryStringPrefix = "?";
1110

12-
const project = getSettings().bugReporting.project;
11+
const project = "https://github.com/PowerShell/vscode-powershell";
1312
const issuesUrl = `${project}/issues/new`;
1413

1514
const extensions =

src/session.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -625,6 +625,7 @@ Type 'help' to get help.
625625
const clientOptions: LanguageClientOptions = {
626626
documentSelector: this.documentSelector,
627627
synchronize: {
628+
// TODO: This is deprecated and they should be pulled by the server.
628629
// backend uses "files" and "search" to ignore references.
629630
configurationSection: [utils.PowerShellLanguageId, "files", "search"],
630631
// TODO: fileEvents: vscode.workspace.createFileSystemWatcher('**/.eslintrc')
@@ -657,6 +658,7 @@ Type 'help' to get help.
657658
this.languageClient = new LanguageClient("PowerShell Editor Services", connectFunc, clientOptions);
658659

659660
// This enables handling Semantic Highlighting messages in PowerShell Editor Services
661+
// TODO: We should only turn this on in preview.
660662
this.languageClient.registerProposedFeatures();
661663

662664
this.languageClient.onTelemetry((event) => {

src/settings.ts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ export class Settings extends PartialSettings {
2525
codeFolding = new CodeFoldingSettings();
2626
codeFormatting = new CodeFormattingSettings();
2727
integratedConsole = new IntegratedConsoleSettings();
28-
bugReporting = new BugReportingSettings();
2928
sideBar = new SideBarSettings();
3029
pester = new PesterSettings();
3130
buttons = new ButtonSettings();
@@ -66,10 +65,6 @@ export enum CommentType {
6665

6766
export type PowerShellAdditionalExePathSettings = Record<string, string>;
6867

69-
class BugReportingSettings extends PartialSettings {
70-
project = "https://github.com/PowerShell/vscode-powershell";
71-
}
72-
7368
class CodeFoldingSettings extends PartialSettings {
7469
enable = true;
7570
showLastLine = true;

0 commit comments

Comments
 (0)