Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use native css custom properties when available #3339

Closed
sorvell opened this issue Jan 27, 2016 · 12 comments
Closed

Use native css custom properties when available #3339

sorvell opened this issue Jan 27, 2016 · 12 comments
Assignees
Labels

Comments

@sorvell
Copy link
Contributor

sorvell commented Jan 27, 2016

Currently, even when native css custom properties are available, Polymer still shims css custom properties. We cannot simply turn off the shimming in this case because Polymer uses an unimplemented but proposed native feature @apply.

We'll need to shim @apply as css custom properties to be able to use native css custom properties.

@sorvell sorvell added the p1 label Jan 27, 2016
@sorvell sorvell self-assigned this Jan 27, 2016
@mgiuffrida
Copy link
Contributor

Great, glad to see this is high priority! 👍

@abdonrd
Copy link
Contributor

abdonrd commented Jan 27, 2016

👍

2 similar comments
@klebba
Copy link

klebba commented Jan 28, 2016

👍

@Jamtis
Copy link

Jamtis commented Jan 28, 2016

👍

@ebidel
Copy link
Contributor

ebidel commented Jun 1, 2016

Any word on this @sorvell? I think some of this has landed?

@ebidel
Copy link
Contributor

ebidel commented Jul 26, 2016

This landed as an opt-in features in 1.6.0!

https://www.polymer-project.org/1.0/docs/release-notes#v-1-6-0

@ebidel ebidel closed this as completed Jul 26, 2016
@mgiuffrida
Copy link
Contributor

mgiuffrida commented Jul 26, 2016

It does have several issues, so buyer beware: #3802 #3803 #3800 #3801 #3806 (some fixed in master)

@ebidel
Copy link
Contributor

ebidel commented Jul 26, 2016

Reopening for @sorvell to close when he things this is ready for mass exposure.

@ebidel ebidel reopened this Jul 26, 2016
@abdonrd
Copy link
Contributor

abdonrd commented Aug 17, 2016

@ebidel ready? :)

@ebidel
Copy link
Contributor

ebidel commented Aug 17, 2016

Seems like all the open issues are closed.

@ebidel ebidel closed this as completed Aug 17, 2016
@mgiuffrida
Copy link
Contributor

we switched it on in Chrome WebUI and nothing has caught fire yet

@abdonrd
Copy link
Contributor

abdonrd commented Aug 17, 2016

Nice! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants