Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[0.8] body unresolved broken #1271

Closed
IntranetFactory opened this issue Mar 9, 2015 · 7 comments
Closed

[0.8] body unresolved broken #1271

IntranetFactory opened this issue Mar 9, 2015 · 7 comments
Assignees
@sorvell
Labels
p2

Comments

@IntranetFactory
Copy link

To prevent FOUC we used, as suggested, <body unresolved>. webcomponents.js always define the style for unresolved - so the body still gets hidden.

But it seems that in 0.8 the unresolved is never removed from body.

If I don't use unresolved I see the page but again get FOUC in FF & IE.
@IntranetFactory
Copy link
Author

In webcomponents/webcomponentsjs#230 I've proposed a workaround which solved that issue for me. But it was classified as not being ok.

@sorvell sorvell added the 0.8 label Mar 10, 2015
@ebidel
Copy link
Contributor

ebidel commented Apr 5, 2015

Running into this too

@addyosmani
Copy link
Member

Confirmed that I've been bitten by this too, but I agree with @garlicnation's resolution on that bug. It's fine for the framework or user to remove the unresolved attribute at a time they consider the page ready.

@IntranetFactory
Copy link
Author

I've a page with several components. I've no problem to remove unresolved myself - but how do I know that all components are ready and won't cause any FOUC?

@ebidel
Copy link
Contributor

ebidel commented Apr 6, 2015

@addyosmani, unresolved was always something users had to manage themselves if they were just using the wc.js polyfill (though IIRC, there was a time before when wc.js did this too). If authoring 0.5 Polymer elements, unresolved was removed by Polymer as a sugaring feature.

@ghost
Copy link

ghost commented May 1, 2015

I ran into this, too.
If it helps, the following will never fire in 0.8:

window.addEventListener("polymer-ready", function() {
    console.log("Event broken?");
}, false);

@sorvell
Copy link
Contributor

sorvell commented May 22, 2015

Id would be best if the webcomponents.js polyfills would take care of this issue, but doing so would break support for Polymer 0.5. That said, it seems reasonable and simple for Polymer to auto-remove this attribute at the appropriate time.

@sorvell sorvell added p2 and removed 0.8 labels May 22, 2015
@sorvell sorvell self-assigned this May 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sorvell sorvell

Labels
p2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sorvell @addyosmani @ebidel @IntranetFactory