Update tests

* Add test for implementing `observedAttributes` * Remove call to `super.id` for legacy browser support.
Polymer · Nov 21, 2017 · 82cf96b · 82cf96b
1 parent feac932
commit 82cf96b
Showing 1 changed file with 11 additions and 6 deletions.
diff --git a/test/unit/polymer.properties-element.html b/test/unit/polymer.properties-element.html
@@ -47,12 +47,13 @@
         set noStomp(value) {}
 
         get id() {
-          return super.id;
+          return this._getProperty('id');
         }
 
         set id(value) {
           this._setProperty('id', value);
-          super.id = value;
+          // cannot call super cuz older browsers
+          this._propertyToAttribute('id');
         }
 
         connectedCallback() {
@@ -93,6 +94,10 @@
 
       class SubElement extends window.MyElement {
 
+        static get observedAttributes() {
+          return ['custom-observed-attr'].concat(super.observedAttributes);
+        }
+
         static get properties() {
           return {
             prop2: String
@@ -203,13 +208,13 @@
 
   <test-fixture id="sub-element-attr">
     <template>
-      <sub-element prop="attr" prop2="attr"></sub-element>
+      <sub-element prop="attr" prop2="attr" custom-observed-attr="custom"></sub-element>
     </template>
   </test-fixture>
 
   <test-fixture id="sub-mixin-element-attr">
     <template>
-      <sub-mixin-element prop="attr" prop2="attr" prop3="attr" mixin="5"></sub-mixin-element>
+      <sub-mixin-element prop="attr" prop2="attr" prop3="attr" mixin="5" custom-observed-attr="custom"></sub-mixin-element>
     </template>
   </test-fixture>
 
@@ -321,7 +326,7 @@
       var fixtureEl = fixture('sub-element-attr');
       assert.equal(fixtureEl.prop, 'attr');
       assert.equal(fixtureEl.prop2, 'attr');
-      assert.equal(fixtureEl._callAttributeChangedCallback, 2);
+      assert.equal(fixtureEl._callAttributeChangedCallback, 3);
     });
 
   });
@@ -374,7 +379,7 @@
       assert.strictEqual(fixtureEl.prop2, 'attr');
       assert.strictEqual(fixtureEl.prop3, 'attr');
       assert.strictEqual(fixtureEl.mixin, 5);
-      assert.equal(fixtureEl._callAttributeChangedCallback, 4);
+      assert.equal(fixtureEl._callAttributeChangedCallback, 5);
     });
 
   });