-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Progress output during format conversion #31
Comments
I've thrown some absolute basics here: It doesn't tell you how far through you are relative to any total, but at least you can see that things are still happening. |
That's a very good point. Not having any feedback when it takes a long time to convert a big file is not ideal. I think a byte-based approach might be the way to go here. We could add a progress attribute to both |
Actually I did add some more to main...sparrowt:show-progress since my comment above, so the 2nd commit now prints out bytes-based progress without any threading (though no Mojo yet). I can open a PR from that branch if you think it's an acceptable approach |
Ah that would be great 🙏 . The reason I mentioned threads is that I was envisioning a generic solution that can be used with any parsing class. Benefits that I can think of would be:
Do you reckon we can go in this direction with your changes? |
Yeah that's a fair point - currently I don't have time to dedicate to this any more (sorry!) but I've opened #32 for now if you're willing to consider it as an interim / stepping stone. |
Description
It would be lovely to have some CLI progress output during format conversion, otherwise it's hard to know if something is hung / how long you're going to need to wait.
I've thought this before but just filing this for now before I forget - not sure I'll have time to submit a PR at the moment.
Steps to Reproduce
austin2speedscope trace.austin trace.json
Expected behavior: Some progress output so that I don't give up / have an idea how much time I have to fill with another task
Actual behavior: Zero console output
Reproduces how often: 100%
Versions
austin-python==1.7.1
The text was updated successfully, but these errors were encountered: