enable a "bad" feature make the whole tenant down

[canadacubachina]

Describe the bug

when i enable a feature which produces error, then the whole tenant get 500 in spite of diff. URLs.
Interesting thing , my Default site always get 500, but other tenant site still work smoothly.

Orchard Core version

2.1.4

To Reproduce

Expected behavior

at least , I can login to the admin panel to disable the feature

Logs and screenshots

[hishamco]

It depends. What is the issue that causes the crash?

[Piedone]

Since you can write any code in a module, you can also write code that e.g. causes an unhandled exception on every page load.

What do you think can be a solution?

[canadacubachina]

I run it locally with SQLite , and enable the feature , it worked very well without exception, got green notification on the top

[hishamco]

Check the logs

[Piedone]

I run it locally with SQLite , and enable the feature , it worked very well without exception, got green notification on the top

Sorry, but this doesn't help to understand your suggestion for cases when a module contains seriously breaking. To reiterate:

Since you can write any code in a module, you can also write code that e.g. causes an unhandled exception on every page load.
What do you think can be a solution?

[canadacubachina]

Since you can write any code in a module, you can also write code that e.g. causes an unhandled exception on every page load.

What do you think can be a solution?

Actually , I answered your question which meant that my code was no problem , at least locally.

the stange thing is even clicking enable a feature get 500 for that feature , it should not influence the whole got 500 with any urls. orchardcore should isolate it.
another possibilty is my azure is on free tier, but this also does not make sense to me. if it is too small unstable server, it will not give out 500

[Piedone]

The fundamental problem, or circumstance, is, that when you extend OC with your module, you implement part of an ASP.NET Core app in C#. OC only provides you with the way to selectively enable/disable that part, but otherwise, you have all the power of C# and .NET available. Thus, you can ultimately break that app, since your code runs as part of the app, it's not an isolated environment like an Android app.

But the specific case of getting an exception right there on the features screen after enabling a feature (and similarly for themes) is something we could guard against, and roll back the enable. This would at least prevent a module from breaking the app immediately in a way that you can't recover from the admin.

[canadacubachina]

Now i can verify that this is not the issue from my module.
this time, I enable OrchardCore_DataProtection_Azure, perhaps I did not provide OrchardCore__OrchardCore_DataProtection_Azure__BlobName, it gave out An error occurred while executing this request.
But now , even go to https://managingportal.azurewebsites.net/ecommerce/admin
or https://managingportal.azurewebsites.net/ecommerce
it always show: An error occurred while executing this request. make the whole tenant down which is serious issue.
My default is still running
ecommerce is my tenant.