Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI deploy: enable better name conversion #901

Open
josephjclark opened this issue Mar 10, 2025 · 1 comment
Open

CLI deploy: enable better name conversion #901

josephjclark opened this issue Mar 10, 2025 · 1 comment
Assignees

Comments

@josephjclark
Copy link
Collaborator

v2 is more strict about workflow names than v1.

When migrating v1 projects with CLI deploy, we should be able to run a safe slugify function to strip out disallowed characters.

I expect this to be almost a one liner.

I guess the only question is if this creates any kind of sync problem. Do we only convert on first deploy or do we do it always?

@github-project-automation github-project-automation bot moved this to New Issues in v2 Mar 10, 2025
@josephjclark josephjclark self-assigned this Mar 10, 2025
@josephjclark josephjclark changed the title CLI deploy: enable better name conversation CLI deploy: enable better name conversion Mar 10, 2025
@josephjclark
Copy link
Collaborator Author

These real workflow names and step names cause problems:

Workflow-[BNS-1B]-1.Get-FormsList-(Historical-sync):
    name: Workflow [BNS-1B] 1.Get FormsList (Historical sync)
    jobs:
      [BNS-1B]-1.Get-FormsList-(Historical-sync):
        name: [BNS-1B] 1.Get FormsList (Historical sync)
        adaptor: '@openfn/[email protected]'
        body:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: New Issues
Development

No branches or pull requests

1 participant