Challenge 53: k8s debug container sidecars #1833
Open
+286
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commjoen
reviewed
Feb 15, 2025
commjoen
reviewed
Feb 15, 2025
commjoen
reviewed
Feb 15, 2025
|
checking now :) |
12 tasks
Pastekitoo
force-pushed
the
Pastekitoo-PR-week1
branch
from
d28ec43 to
28cb549
Compare
commjoen
requested changes
Mar 9, 2025
There was a problem hiding this comment.
Hi @Pastekitoo almost there!
here are a few changes we would still need :) .
Next stop: the k8s integrations themselves :)
src/main/java/org/owasp/wrongsecrets/challenges/kubernetes/Challenge53.java
Outdated
Show resolved
Hide resolved
src/main/java/org/owasp/wrongsecrets/challenges/kubernetes/Challenge53.java
Outdated
Show resolved
Hide resolved
…llenge53.java Co-authored-by: Jeroen Willemsen <[email protected]>
Co-authored-by: Jeroen Willemsen <[email protected]>
Co-authored-by: Jeroen Willemsen <[email protected]>
Co-authored-by: Jeroen Willemsen <[email protected]>
Co-authored-by: Jeroen Willemsen <[email protected]>
|
I will have to test if Azure and AWS are sufficiently equipped to host the challenge . Other than that: LGTM. @bendehaan can you review as well please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of changes does this PR include?
Description
Relations
Closes #1236
References
Checklist: