Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: ONSdigital/statistical-methods-library
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 12.0.0-rc10
Choose a base ref
...
head repository: ONSdigital/statistical-methods-library
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: main
Choose a head ref
8 contributors

Commits on May 16, 2023

  1. Adding Back Data To Weighting + Weight At Period/Group Level Not Peri… 

    …od/Ref Level
    @Piwington
    Piwington committed May 16, 2023
    Copy the full SHA
    88a183a View commit details

  2. Fix some breakages in mean of ratios which were not spotted due to th… 

    …e focus on weighting
    @arthompson
    arthompson committed May 16, 2023
    Copy the full SHA
    f68413a View commit details

  3. 49 Main Test Passes. Back Data Test Fails. Possible Cartesian product?

    @Piwington
    Piwington committed May 16, 2023
    Copy the full SHA
    e2cd08f View commit details

  4. No Growth Needed As No Calculations Occur

    @Piwington
    Piwington committed May 16, 2023
    Copy the full SHA
    e4e8610 View commit details

  5. Need to select these to get them out.

    @Piwington
    Piwington committed May 16, 2023
    Copy the full SHA
    1a83cdf View commit details

  6. Update

    @Piwington
    Piwington committed May 16, 2023
    Copy the full SHA
    20be8fe View commit details

  7. Moving logic around, not expected to work properly

    @arthompson
    arthompson committed May 16, 2023
    Copy the full SHA
    bd4ebeb View commit details

  8. Another intermediate logic moving commit to remove unnecessary subfun… 

    …ctions
    @arthompson
    arthompson committed May 16, 2023
    Copy the full SHA
    33ecada View commit details

  9. Separate out period calculation utility functions

    @arthompson
    arthompson committed May 16, 2023
    Copy the full SHA
    223df40 View commit details

  10. Put back more of the weighting code

    @arthompson
    arthompson committed May 16, 2023
    Copy the full SHA
    b5106d0 View commit details

  11. Move a couple of logic blocks around to combine if statements

    @arthompson
    arthompson committed May 16, 2023
    Copy the full SHA
    b749522 View commit details

  12. Unproduced Columns

    @Piwington
    Piwington committed May 16, 2023
    Copy the full SHA
    2a57497 View commit details

  13. ratio calculation no longer needs to be in its own function so flatte… 

    …n the logic
    @arthompson
    arthompson committed May 16, 2023
    Copy the full SHA
    e1a6856 View commit details

Commits on May 17, 2023

  1. Fix unprotected use of back data related data frames

    @arthompson
    arthompson committed May 17, 2023
    Copy the full SHA
    1a8dc12 View commit details

  2. First Weighted Test Passes

    @Piwington
    Piwington committed May 17, 2023
    Copy the full SHA
    031fadf View commit details

  3. Add Tests To TOML.

    @Piwington
    Piwington committed May 17, 2023
    Copy the full SHA
    1a87a0e View commit details

  4. Calculate_ratios as a function but not a stage just structural so we … 

    …can return early
    @arthompson
    arthompson committed May 17, 2023
    Copy the full SHA
    0148f27 View commit details

  5. Update TOML

    @Piwington
    Piwington committed May 17, 2023
    Copy the full SHA
    f045c3d View commit details

  6. We need people to pass decimals as weights to avoid floating point ma… 

    …dness
    @arthompson
    arthompson committed May 17, 2023
    Copy the full SHA
    3a24dd1 View commit details

  7. Configure fields and types in toml

    @arthompson
    arthompson committed May 17, 2023
    Copy the full SHA
    d17b31a View commit details

  8. More Weight Tests. Removed Bad Tests, Will Feedback To Ellie.

    @Piwington
    Piwington committed May 17, 2023
    Copy the full SHA
    6dcd14a View commit details

  9. Now imputation methodology scenarios are fully configurable use a sin… 

    …gle test runner for mean of ratios and ratio of means
    @arthompson
    arthompson committed May 17, 2023
    Copy the full SHA
    57bd62e View commit details

  10. Hopefully fix multiple config issues

    @arthompson
    arthompson committed May 17, 2023
    Copy the full SHA
    f17772d View commit details

  11. Swap imputation tests to pyspark-test rather than chispa 

    The chispa errors may have been all nicely coloured but, as a blind
developer, my current screen access setup doesn't make it easy to get the
text colours and the tables were just painful to read (I've had to resort to
reading the terminal escape sequences in the past). After spending about 5
hours trying to track down a test error today it seems somewhat unproductive
to keep the coloured error messages when there's another library which can
do simpler errors more in the spirit of output diffs.
    @arthompson
    arthompson committed May 17, 2023
    Copy the full SHA
    f7abf62 View commit details

Commits on May 18, 2023

  1. pyspark-test was stopping on the first error but we probably want the… 

    … entire diff so switch to the (probably slower) pytest assert check on the df collects
    @arthompson
    arthompson committed May 18, 2023
    Copy the full SHA
    843d30c View commit details

  2. Remove chispa

    @arthompson
    arthompson committed May 18, 2023
    Copy the full SHA
    efca57f View commit details

  3. Swap from bround to just casting decimal precision

    @arthompson
    arthompson committed May 18, 2023
    Copy the full SHA
    369a2a8 View commit details

  4. Log missing columns

    @arthompson
    arthompson committed May 18, 2023
    Copy the full SHA
    dfc7bdc View commit details

  5. Bad Params + Change Test Base Of Ellie's Feedback

    @Piwington
    Piwington committed May 18, 2023
    Copy the full SHA
    ab2c16b View commit details

  6. Revert

    @Piwington
    Piwington committed May 18, 2023
    Copy the full SHA
    4548437 View commit details

  7. Correctly handle scenario specific kwargs

    @arthompson
    arthompson committed May 18, 2023
    Copy the full SHA
    c2cfb56 View commit details

  8. New dataframe comparer

    @arthompson
    arthompson committed May 18, 2023
    Copy the full SHA
    ac36ba1 View commit details

  9. More Tests Done.

    @Piwington
    Piwington committed May 18, 2023
    Copy the full SHA
    d3e62d2 View commit details

  10. Make data frame comparer actually fail when data frames do not match

    @arthompson
    arthompson committed May 18, 2023
    Copy the full SHA
    cf6046d View commit details

  11. Tests Adjustments - Unfinished

    @Piwington
    Piwington committed May 18, 2023
    Copy the full SHA
    46c242c View commit details

  12. test comparison improvements

    @arthompson
    arthompson committed May 18, 2023
    Copy the full SHA
    bf9cbfe View commit details

  13. Fix incorrect drop logic in df comparer

    @arthompson
    arthompson committed May 18, 2023
    Copy the full SHA
    49ba900 View commit details

  14. Test Fixes

    @Piwington
    Piwington committed May 18, 2023
    Copy the full SHA
    bcf5c3e View commit details

  15. Provide comparison as df1 and df2 paired in column maps

    @arthompson
    arthompson committed May 18, 2023
    Copy the full SHA
    84e46d7 View commit details

  16. Make outliering tests use new comparer

    @arthompson
    arthompson committed May 18, 2023
    Copy the full SHA
    d480e31 View commit details

  17. Make estimation tests use new comparer

    @arthompson
    arthompson committed May 18, 2023
    Copy the full SHA
    7bfe5ae View commit details

  18. Start outputting rows as strings rather than the show string

    @arthompson
    arthompson committed May 18, 2023
    Copy the full SHA
    e976a38 View commit details

  19. Alter comparer to output expected and actual

    @arthompson
    arthompson committed May 18, 2023
    Copy the full SHA
    f74e972 View commit details

  20. Make outliering use new comparer args

    @arthompson
    arthompson committed May 18, 2023
    Copy the full SHA
    b71e877 View commit details

  21. reformat with black and isort

    @arthompson
    arthompson committed May 18, 2023
    Copy the full SHA
    ce6ba58 View commit details

Commits on May 19, 2023

  1. Preserve row ordering in comparer

    @arthompson
    arthompson committed May 19, 2023
    Copy the full SHA
    eb32507 View commit details

Commits on May 22, 2023

  1. Ellie Confirmed Test Removal. New Test Added

    @Piwington
    Piwington committed May 22, 2023
    Copy the full SHA
    d059e70 View commit details

  2. New Test

    @Piwington
    Piwington committed May 22, 2023
    Copy the full SHA
    ede2d55 View commit details

  3. Last Test Added. Renumbered To Account For Removed Tests. Last MoR Te… 

    …st Failing, Need To Fix.
    @Piwington
    Piwington committed May 22, 2023
    Copy the full SHA
    b4c7d54 View commit details

  4. New output format for comparer

    @arthompson
    arthompson committed May 22, 2023
    Copy the full SHA
    e42c6f1 View commit details
Loading