Merge pull request #142 from ONSdigital/extrenuous_drop

Extraneous Drop

Author: Piwington

docs/release-notes/9.1.1.md

@@ -0,0 +1,17 @@
+# Statistical Methods Library 9.1.1
+
+Release date: 2023-02-07
+
+## Synopsis
+
+This release removes a piece of unused code in back data handling.
+
+## Changes
+
+In the Ratio of Means imputation method, an attempt was made to drop a
+non-existent column (the input target column) from the back data. This was
+silently failing and so has been removed.
+
+## Notes
+
+This change has no functional impact.

pyproject.toml

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "statistical_methods_library"
-version = "9.1.0"
+version = "9.1.1"
 description = ""
 authors = ["Your Name <you@example.com>"]
 license = "MIT"

statistical_methods_library/imputation/ratio_of_means.py

@@ -290,7 +290,6 @@ def prepare_df(df: DataFrame) -> DataFrame:
                         & (col(marker_col) != lit(Marker.BACKWARD_IMPUTE.value))
                     )
                 )
-                .drop("target")
                 .withColumn("previous_period", calculate_previous_period(col("period")))
                 .withColumn("next_period", calculate_next_period(col("period")))
             )