Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codacy should be included in trusted badges domains. #8662

Closed
developer-ken opened this issue Jun 26, 2021 · 3 comments · Fixed by #8687
Closed

Codacy should be included in trusted badges domains. #8662

developer-ken opened this issue Jun 26, 2021 · 3 comments · Fixed by #8687
Assignees

Comments

@developer-ken
Copy link

Codacy Badge

I want to add this badage and found a warning that it is not in the list of trusted domains.
Maybe this site can be trusted.

@joelverhagen
Copy link
Member

Thanks @developer-ken for taking the time to open this issue. Our team will evaluate this host against our security and privacy requirements.

@joelverhagen joelverhagen added this to the Sprint 2021-07 milestone Jun 29, 2021
@lyndaidaii
Copy link
Contributor

@developer-ken, we actually support api.codacy.com(https://docs.microsoft.com/en-us/nuget/nuget-org/package-readme-on-nuget-org#allowed-domains-for-images-and-badges)
I checked the codacy how they generate the badges. They also support app.codacy.com for bages.

This domain is satisfy our privacy and security requirement.
Would you like to open a PR to include app.coday.com?

Here is file we added new domain into list
https://github.com/NuGet/NuGetGallery/blob/db62de43e24b704e9ab16d8abc39bdfa3e73260b/src/NuGetGallery/App_Data/Files/Content/Trusted-Image-Domains.json

@developer-ken
Copy link
Author

developer-ken commented Jul 20, 2021

I was busy with my school project and didnt keep track of this issue for some time. By reading comments above I guess the issue is solved by PR #8687. Maybe I close this issue?

Edit:
Oh I see NuGet/docs.microsoft.com-nuget#2485 or maybe I should close the issue after that PR is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants