Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ncclIbIsend() double check "comm->base.ready" #1631

Open
ecjtusbs opened this issue Mar 4, 2025 · 1 comment
Open

ncclIbIsend() double check "comm->base.ready" #1631

ecjtusbs opened this issue Mar 4, 2025 · 1 comment

Comments

@ecjtusbs
Copy link

ecjtusbs commented Mar 4, 2025

ncclIbIsend() double check "comm->base.ready"

if (comm->base.ready == 0) { WARN("NET/IB: ncclIbIsend() called when comm->base.ready == 0"); return ncclInternalError; }

if (comm->base.ready == 0) { *request = NULL; return ncclSuccess; }

if (comm->base.ready == 0) { WARN("NET/IB: ncclIbIsend() called when comm->base.ready == 0"); return ncclInternalError; }
if (comm->base.ready == 0) { *request = NULL; return ncclSuccess; } //when should we arrive here?

@GeofferyGeng
Copy link

It seems that this issue has been mentioned in #1489

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants