Merge pull request #302 from MyEtherWallet/devop/address-select-save

Devop: address select display save icon option

Author: gamalielhere

CHANGELOG.md

@@ -1,3 +1,8 @@
+### Release 1.3.4
+### devop
+- allow users to hide address select save icon [#302](https://github.com/MyEtherWallet/mew-components/pull/302)
+- fix persistent hint [#303](https://github.com/MyEtherWallet/mew-components/pull/303)
+
 ### Release 1.3.3
 
 ### devop

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "@myetherwallet/mew-components",
-  "version": "1.3.3",
+  "version": "1.3.4",
   "description": "MEW Components",
   "main": "dist/mew-components.umd.js",
   "module": "dist/mew-components.esm.js",
@@ -11,7 +11,7 @@
   "private": false,
   "scripts": {
     "serve": "vue-cli-service serve",
-    "lint": "vue-cli-service lint && eslint . --ext .js --ext .vue",
+    "lint": "vue-cli-service lint && eslint . --ext .js --ext .vue --fix",
     "build": "npm run build:umd & npm run build:es & npm run build:unpkg",
     "build-bundle": "vue-cli-service build --target lib --name mew-components ./src/wrapper.js",
     "build:umd": "rollup --config rollup.config.js --format umd --file dist/mew-components.umd.js",

package.json

@@ -16,7 +16,7 @@
     :disabled="disabled"
     :error-messages="errorMessages"
     :hint="hint || resolvedAddr || ''"
-    :persistent-hint="resolvedAddr.length > 0"
+    :persistent-hint="resolvedAddr.length > 0 || hint.length > 0"
     :rules="rules"
     :no-data-text="noDataText"
     :menu-props="{ value: dropdown, closeOnClick: true }"
@@ -57,6 +57,7 @@
           :copy-value="addressValue.address || addressValue"
         />
         <v-tooltip
+          v-if="showSave"
           content-class="tooltip-inner"
           color="titlePrimary--text"
           top
@@ -234,6 +235,13 @@ export default {
       type: Boolean,
       default: true
     },
+    /**
+     * Displays save button.
+     */
+    showSave: {
+      type: Boolean,
+      default: true
+    },
     /**
      * Tooltip text for save address icon.
      */

src/components/MewAddressSelect/MewAddressSelect.vue

@@ -14,8 +14,8 @@ export default {
     component: MewAddressSelect,
     docs: {
       page: MewAddressSelectDoc,
-      inlineStories: true
-    }
+      inlineStories: true,
+    },
   },
   decorators: [withKnobs],
 };
@@ -63,6 +63,9 @@ export const MEWAddressSelect = () => ({
     showCopy: {
       default: boolean('show-copy', true),
     },
+    showSave: {
+      default: boolean('show-save', true),
+    },
     noDataText: {
       default: text('no-data-text', ''),
     },
@@ -93,7 +96,7 @@ export const MEWAddressSelect = () => ({
   template: `
     <div>
     <br />
-    <mew-address-select ref="address" :hint="hint" :error-messages="errorMessages" :no-data-text="noDataText" :rules="rules" :resolved-addr="resolvedAddr" :copy-tooltip="copyTooltip" :save-tooltip="saveTooltip" :disabled="disabled" :enable-save-address="enableSaveAddress" :is-valid-address="isValidAddress" :show-copy="showCopy" :label="label" :items="items" @saveAddress="onSaveAddress" @input="onSelectValue"/>
+    <mew-address-select ref="address" :show-save="showSave" :hint="hint" :error-messages="errorMessages" :no-data-text="noDataText" :rules="rules" :resolved-addr="resolvedAddr" :copy-tooltip="copyTooltip" :save-tooltip="saveTooltip" :disabled="disabled" :enable-save-address="enableSaveAddress" :is-valid-address="isValidAddress" :show-copy="showCopy" :label="label" :items="items" @saveAddress="onSaveAddress" @input="onSelectValue"/>
   </div>`,
   methods: {
     onSaveAddress() {