commit build

Author: SteveMieskoski

.eslintrc

@@ -1,10 +1,30 @@
 {
-  extends: [ 'prettier'],
+  root: true,
+  "env": {
+    "node": true,
+    "es6": true,
+    "mocha": true
+  },
+  extends: [
+    'plugin:vue/recommended',
+    '@vue/prettier',
+    'eslint:recommended',
+    'plugin:security/recommended'
+  ],
   rules: {
-    'prefer-destructuring': 'off',
-    'consistent-return': 'off',
-    'no-underscore-dangle': 'off',
-    'no-multi-assign': 'off',
-    'class-methods-use-this': 'off'
-  }
+    'no-console': 'error',
+    'no-debugger': 'error',
+    'no-else-return': ['error', { allowElseIf: true }],
+    'arrow-parens': 'off',
+    'generator-star-spacing': 'off',
+    semi: 'off',
+    'prefer-const': 'error',
+    'no-var': 'error',
+    'security/detect-new-buffer': 'off',
+    'security/detect-object-injection': 'off'
+  },
+  parserOptions: {
+    parser: 'babel-eslint'
+  },
+  plugins: ['security']
 }

dist/index.js

@@ -14,7 +14,7 @@ var debugLogger = _interopDefault(require('debug'));
 var io = _interopDefault(require('socket.io-client'));
 var SimplePeer = _interopDefault(require('simple-peer'));
 
-var version = "1.0.8";
+var version = "1.0.9";
 
 var version$1 = version;
 
@@ -85,7 +85,7 @@ var lifeCycle = {
   sendOffer: 'sendOffer',
   answerReceived: 'answerReceived',
   RtcConnectedEvent: 'RtcConnectedEvent',
-  RtcConnectedEmitted: "RtcConnectedEmitted",
+  RtcConnectedEmitted: 'RtcConnectedEmitted',
   RtcClosedEvent: 'RtcClosedEvent',
   RtcDisconnectEvent: 'RtcDisconnectEvent',
   RtcFailedEvent: 'RtcFailedEvent',
@@ -272,18 +272,17 @@ var MewConnectCommon = function (_EventEmitter) {
       }
       var browserVersion = browser.version.split(0, 1)[0];
       /*
-      * Chrome > 23
-      * Firefox > 22
-      * Opera > 18
-      * Safari > 11 (caveats exist)
-      * Edge - none (RTCDataChannel not supported)
-      * IE - none
-      * */
+       * Chrome > 23
+       * Firefox > 22
+       * Opera > 18
+       * Safari > 11 (caveats exist)
+       * Edge - none (RTCDataChannel not supported)
+       * IE - none
+       * */
       if (typeof window !== 'undefined') {
         if (browser.name === 'safari') {
           // eslint-disable-next-line global-require
           require('webrtc-adapter');
-          // console.log(adapter); // todo remove dev item
           return MewConnectCommon.buildBrowserResult(true, 'Safari', 'version: ' + browser.version);
         }
         if (browser.name === 'ie') {
@@ -1013,7 +1012,6 @@ var MewConnectInitiator = function (_MewConnectCommon) {
       this.socketEmit(this.signals.rtcConnected, this.socketKey);
       this.socketDisconnect();
       this.uiCommunicator(this.lifeCycle.RtcConnectedEvent);
-      this.uiCommunicator(this.lifeCycle.RtcConnectedEvent);
     }
   }, {
     key: 'onData',

package-lock.json

@@ -2,8 +2,7 @@
   "name": "@myetherwallet/mewconnect-web-client",
   "homepage": "https://github.com/myetherwallet/MEWconnect-web-client",
   "version": "1.0.9",
-  "main": "./src",
-  "distMain": "./dist/index.js",
+  "main": "./dist/index.js",
   "scripts": {
     "start": "node ./example/peer_server/www.js",
     "test:jest": "jest --detectOpenHandles --forceExit --runInBand",
@@ -32,7 +31,11 @@
     "webrtc-adapter": "^6.4.3"
   },
   "devDependencies": {
+    "@vue/cli-plugin-babel": "3.4.0",
+    "@vue/cli-plugin-eslint": "3.4.0",
+    "@vue/eslint-config-prettier": "^4.0.1",
     "babel-core": "^6.26.3",
+    "babel-eslint": "^10.0.1",
     "babel-jest": "*",
     "babel-loader": "^7.1.5",
     "babel-plugin-external-helpers": "^6.22.0",
@@ -48,6 +51,7 @@
     "eslint-config-airbnb-base": "^13.1.0",
     "eslint-config-prettier": "^3.0.1",
     "eslint-plugin-import": "^2.14.0",
+    "eslint-plugin-security": "^1.4.0",
     "jest": "^23.6.0",
     "nyc": "^13.0.1",
     "opn": "^5.4.0",

package.json

@@ -89,18 +89,18 @@ export default class MewConnectCommon extends EventEmitter {
 
   static checkBrowser() {
     let browser = detect();
-    if(browser === null){
-      browser = {version: {split: () => [1]}}
+    if (browser === null) {
+      browser = { version: { split: () => [1] } };
     }
     const browserVersion = browser.version.split(0, 1)[0];
     /*
-    * Chrome > 23
-    * Firefox > 22
-    * Opera > 18
-    * Safari > 11 (caveats exist)
-    * Edge - none (RTCDataChannel not supported)
-    * IE - none
-    * */
+     * Chrome > 23
+     * Firefox > 22
+     * Opera > 18
+     * Safari > 11 (caveats exist)
+     * Edge - none (RTCDataChannel not supported)
+     * IE - none
+     * */
     if (typeof window !== 'undefined') {
       if (browser.name === 'safari') {
         // eslint-disable-next-line global-require

src/MewConnectCommon.js

@@ -346,7 +346,8 @@ export default class MewConnectInitiator extends MewConnectCommon {
     this.p.on(this.rtcEvents.signal, signalListener.bind(this));
     this.p._pc.addEventListener('iceconnectionstatechange', evt => {
       // eslint-disable-next-line no-undef
-      if(typeof jest === 'undefined'){ // included because target is not defined in jest
+      if (typeof jest === 'undefined') {
+        // included because target is not defined in jest
         debug(`iceConnectionState: ${evt.target.iceConnectionState}`);
         if (
           evt.target.iceConnectionState === 'connected' ||

src/MewConnectInitiator.js

@@ -79,7 +79,7 @@ const lifeCycle = {
   sendOffer: 'sendOffer',
   answerReceived: 'answerReceived',
   RtcConnectedEvent: 'RtcConnectedEvent',
-  RtcConnectedEmitted: "RtcConnectedEmitted",
+  RtcConnectedEmitted: 'RtcConnectedEmitted',
   RtcClosedEvent: 'RtcClosedEvent',
   RtcDisconnectEvent: 'RtcDisconnectEvent',
   RtcFailedEvent: 'RtcFailedEvent',