Skip to content

Commit 93f77cb

Browse files
TerrorJackMoLow
authored andcommitted
build: set v8_enable_webassembly=false when lite mode is enabled
We should set v8_enable_webassembly=false when lite mode is enabled, since v8_enable_lite_mode implies v8_jitless, and wasm currently doesn't work with jitless. This is automatically handled in gn, but seems to be not the case in gyp. Enabling lite mode without setting v8_enable_webassembly=false leads to "Warning: disabling flag --expose_wasm due to conflicting flags" at runtime. PR-URL: nodejs#48248 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
1 parent 36bf069 commit 93f77cb

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

configure.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -1524,7 +1524,7 @@ def configure_library(lib, output, pkgname=None):
15241524

15251525

15261526
def configure_v8(o):
1527-
o['variables']['v8_enable_webassembly'] = 1
1527+
o['variables']['v8_enable_webassembly'] = 0 if options.v8_lite_mode else 1
15281528
o['variables']['v8_enable_javascript_promise_hooks'] = 1
15291529
o['variables']['v8_enable_lite_mode'] = 1 if options.v8_lite_mode else 0
15301530
o['variables']['v8_enable_gdbjit'] = 1 if options.gdb else 0

0 commit comments

Comments
 (0)