We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ImageLoader
url
When using a bad image url for a UImage :
UImage
UImage(url: $viewModel.map({ $0?.image }), loader: .defaultFade)
The existing image is kept, this is a problem when reusing a UImage.
Since ImageLoader does check the url is 'valid', perhaps it should reset the image before returning? https://github.com/MihaelIsaev/UIKitPlus/blob/master/Classes/Objects/ImageLoader.swift#L44
The text was updated successfully, but these errors were encountered:
Also wonder why a dispatch on the loaderQueue is queued from a .main dispatch? https://github.com/MihaelIsaev/UIKitPlus/blob/master/Classes/Objects/ImageLoader.swift#L38
loaderQueue
.main
Why not simplify and simply dispatch on the loaderQueue.
Sorry, something went wrong.
No branches or pull requests
When using a bad image url for a
UImage
:The existing image is kept, this is a problem when reusing a
UImage
.Since
ImageLoader
does check the url is 'valid', perhaps it should reset the image before returning?https://github.com/MihaelIsaev/UIKitPlus/blob/master/Classes/Objects/ImageLoader.swift#L44
The text was updated successfully, but these errors were encountered: