Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown preview does not handle links with parentheses #380

Closed
dend opened this issue Nov 20, 2015 · 6 comments
Closed

Markdown preview does not handle links with parentheses #380

dend opened this issue Nov 20, 2015 · 6 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug markdown Markdown support issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Milestone

Comments

@dend
Copy link

dend commented Nov 20, 2015

The Common Markdown spec covers the possibility of having links with parentheses (which should be considered valid links regardless).

Here is an example where the preview engine in VSCode mis-renders those:
image3

@jepessen
Copy link
Contributor

@dend
Copy link
Author

dend commented Nov 21, 2015

@jepessen SO actually fixed that and inline p-based links are now rendered properly there.

@bpasero
Copy link
Member

bpasero commented Nov 23, 2015

@dend We are using https://github.com/chjj/marked to render the preview, can I ask you to file the bug there?

@bpasero
Copy link
Member

bpasero commented Nov 23, 2015

Btw 👍 for the workarounds in that SO thread, seems to work nicely also for VS Code.

@dend
Copy link
Author

dend commented Nov 23, 2015

Sure, will open a bug there :)

As for workarounds - sure, they work. But these are workarounds rather than a robust solution.

@bpasero
Copy link
Member

bpasero commented Nov 23, 2015

Thanks.

@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug upstream Issue identified as 'upstream' component related (exists outside of VS Code) and removed bug Issue identified by VS Code Team member as probable bug labels Nov 24, 2015
@bpasero bpasero modified the milestone: Backlog Nov 26, 2015
@bpasero bpasero added the markdown Markdown support issues label Mar 21, 2016
@bpasero bpasero closed this as completed Jun 16, 2016
@bpasero bpasero modified the milestones: June 2016, Backlog Jun 16, 2016
@bpasero bpasero assigned kieferrm and unassigned bpasero Jun 16, 2016
@dbaeumer dbaeumer added the verified Verification succeeded label Jul 1, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug markdown Markdown support issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

5 participants