Skip to content

Commit d9b59de

Browse files
bnoordhuisBridgeAR
authored andcommittedJan 21, 2018
build,test: make building addon tests less fragile
* Get rid of recursive `make` when building the node binary. An earlier commit makes GYP write out rules that we can use for proper dependency tracking. * Use module name 'binding' in addons.md and addons-napi/*/binding.gyp. This massively simplifies the logic for generating the build rules. * Check in auto-generated add-on tests from `doc/api/addons.md`. The files change rarely and generating them dynamically causes no end of race conditions and special-casing during the build. PR-URL: nodejs#17407 Reviewed-By: Richard Lau <[email protected]>
1 parent c668263 commit d9b59de

File tree

95 files changed

+917
-301
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

95 files changed

+917
-301
lines changed
 

‎.gitignore

-1
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,6 @@ ipch/
7474
/npm.wxs
7575
/tools/msvs/npm.wixobj
7676
/tools/msvs/genfiles/
77-
/test/addons/??_*/
7877
email.md
7978
deps/v8-*
8079
deps/icu

0 commit comments

Comments
 (0)