Commit d9b59de

authored and

committed

Jan 21, 2018

build,test: make building addon tests less fragile

* Get rid of recursive `make` when building the node binary. An earlier commit makes GYP write out rules that we can use for proper dependency tracking. * Use module name 'binding' in addons.md and addons-napi/*/binding.gyp. This massively simplifies the logic for generating the build rules. * Check in auto-generated add-on tests from `doc/api/addons.md`. The files change rarely and generating them dynamically causes no end of race conditions and special-casing during the build. PR-URL: nodejs#17407 Reviewed-By: Richard Lau <[email protected]>

·

1 parent c668263 commit d9b59deCopy full SHA for d9b59de

95 files changed

+917

-301

lines changed

.gitignore
Makefile
doc/api
- addons.md
node.gyp
test
- addons
  - .gitignore
  - 01_function_arguments
  - 02_callbacks
  - 03_object_factory
  - 04_function_factory
  - 05_wrapping_c_objects
  - 06_factory_of_wrapped_objects
  - 07_passing_wrapped_objects_around
  - 08_void_atexitcallback_args
  - openssl-client-cert-engine
    - binding.cc
    - binding.gyp
- addons-napi
  - test_array
    - binding.gyp
    - test.js
  - test_async
    - binding.gyp
    - test-async-hooks.js
    - test.js
  - test_buffer
    - binding.gyp
    - test.js
  - test_constructor
    - binding.gyp
    - test.js
  - test_constructor_name
    - binding.gyp
    - test.js
    - test_constructor_name.c
  - test_conversions
    - binding.gyp
    - test.js
  - test_dataview
    - binding.gyp
    - test.js
  - test_env_sharing
    - binding.gyp
    - test.js
  - test_error
    - binding.gyp
    - test.js
  - test_exception
    - binding.gyp
    - test.js
  - test_fatal
    - binding.gyp
    - test.js
    - test2.js
  - test_function
    - binding.gyp
    - test.js
  - test_general
    - binding.gyp
    - test.js
    - testGlobals.js
    - testInstanceOf.js
    - testNapiRun.js
    - testNapiStatus.js
  - test_handle_scope
    - binding.gyp
    - test.js
  - test_number
    - binding.gyp
    - test.js
  - test_object
    - binding.gyp
    - test.js
  - test_promise
    - binding.gyp
    - test.js
  - test_properties
    - binding.gyp
    - test.js
  - test_reference
    - binding.gyp
    - test.js
  - test_string
    - binding.gyp
    - test.js
  - test_symbol
    - binding.gyp
    - test1.js
    - test2.js
    - test3.js
  - test_typedarray
    - binding.gyp
    - test.js
  - test_uv_loop
    - binding.gyp
    - test.js
  - test_warning
    - binding.gyp
    - test.js
tools/doc
- addon-verify.js

95 files changed

+917

-301

lines changed

`‎.gitignore`

-1

-Original file line number
+Diff line change
 /npm.wxs
 /tools/msvs/npm.wixobj
 /tools/msvs/genfiles/
 -/test/addons/??_*/
 email.md
 deps/v8-*
 deps/icu

Comments

(0)

Please sign in to comment.