Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

send_image and send_images should support aspect ratio parameter #475

Closed
palmer-cl opened this issue Nov 30, 2024 · 2 comments · Fixed by #480
Closed

send_image and send_images should support aspect ratio parameter #475

palmer-cl opened this issue Nov 30, 2024 · 2 comments · Fixed by #480
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@palmer-cl
Copy link
Contributor

It looks like there was a break in the UI causing images sent via api (not the web client) to use a fallback aspect ratio and object-cover causing different size aspect ratios to render incorrectly:

image

When you post through the web client, an aspectRatio is set:

image

Should the send_image function include the ability to set aspect ratio?

image
@palmer-cl
Copy link
Contributor Author

Related pull request: bluesky-social/social-app#6828

@ulrischa
Copy link

Huge issues caused by this breaking api change

@MarshalX MarshalX added enhancement New feature or request good first issue Good for newcomers labels Dec 1, 2024
@palmer-cl palmer-cl mentioned this issue Dec 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add ability to send aspect ratio with send_image and send_images palmer-cl/atproto
3 participants
@ulrischa @MarshalX @palmer-cl