Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

n-level undo should be serializer-neutral #4582

Open
rockfordlhotka opened this issue Mar 6, 2025 · 1 comment
Open

n-level undo should be serializer-neutral #4582

rockfordlhotka opened this issue Mar 6, 2025 · 1 comment

Comments

@rockfordlhotka
Copy link
Member

Right now, the n-level undo code in UndoableBase has some direct dependencies on MobileFormatter.

That should be changed to rely on the configured serializer.

@JasonBock
Copy link
Contributor

FWIW this issue is how I found it. Basically, during BeginEdit(), the configured formatter is given a BusinessRules instance, but since my formatter doesn't see it implement the custom interface I think it should, it failed.

I added code to fall back to MobileFormatter in this case, but this really shouldn't be needed. I wonder if this issue would be the key to rectifying this, at least partially.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

2 participants