Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: rust-lang/rust
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: Manishearth/rust
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: rollup-phupwxa
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 10 commits
  • 12 files changed
  • 3 contributors

Commits on Aug 3, 2020

  1. Use u32::from_le_bytes to fix a FIXME

    @tesuji
    tesuji committed Aug 3, 2020
    Copy the full SHA
    aca0258 View commit details

  2. ci: disable fast-fail on auto-fallible 

    The purpose of the auto-fallible job is to run builders that are likely
to fail on CI without gating on them. Having fast-fail enabled there
kinda defeats the purpose, as if one of them fails we can't monitor the
outcome of the other ones.

This was prompted by the aarch64-gnu builder consistently failing due to
a broken test, preventing us from seeing if the macOS spurious failure
is fixed.
    @pietroalbini
    pietroalbini committed Aug 3, 2020

    Verified

    This commit was signed with the committer’s verified signature.
    pietroalbini Pietro Albini
    GPG key ID: 3E06ABE80BAAF19C
    Verified
    Learn about vigilant mode
    Copy the full SHA
    4657923 View commit details

  3. Rollup merge of #74759 - carbotaniuman:uabs, r=shepmaster 

    add `unsigned_abs` to signed integers

Mentioned on rust-lang/rfcs#2914

This PR simply adds an `unsigned_abs` to signed integers function which returns the correct absolute value as a unsigned integer.
    @Manishearth
    Manishearth authored Aug 3, 2020

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    GPG key ID: 4AEE18F83AFDEB23
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    86d85b6 View commit details

  4. Rollup merge of #75056 - Veykril:path_statements_lint, r=oli-obk 

    Lint path statements to suggest using drop when the type needs drop

Fixes #48852. With this change the current lint description doesn't really fit entirely anymore I think.
    @Manishearth
    Manishearth authored Aug 3, 2020

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    GPG key ID: 4AEE18F83AFDEB23
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    4edd34c View commit details

  5. Rollup merge of #75058 - ssomers:btree_cleanup_insert_2, r=Mark-Simul… 

    …acrum

Clarify reuse of a BTreeMap insert support function and treats split support likewise

r? @Mark-Simulacrum
    @Manishearth
    Manishearth authored Aug 3, 2020

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    GPG key ID: 4AEE18F83AFDEB23
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    b3e6836 View commit details

  6. Rollup merge of #75081 - jyn514:fix-logging, r=Mark-Simulacrum 

    Fix logging for rustdoc

#74726 (comment)
    @Manishearth
    Manishearth authored Aug 3, 2020

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    GPG key ID: 4AEE18F83AFDEB23
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    40a1382 View commit details

  7. Rollup merge of #75083 - JohnTitor:follow-up-unused-braces, r=lcnr 

    Do not trigger `unused_braces` for `while let`

Follow-up for #75031
r? @lcnr
    @Manishearth
    Manishearth authored Aug 3, 2020

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    GPG key ID: 4AEE18F83AFDEB23
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    3902bbd View commit details

  8. Rollup merge of #75086 - lzutao:u32const, r=oli-obk 

    Use u32::from_le_bytes to fix a FIXME

`u32::from_be_bytes` has been const stable since 1.44.
    @Manishearth
    Manishearth authored Aug 3, 2020

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    GPG key ID: 4AEE18F83AFDEB23
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    f414f2a View commit details

  9. Rollup merge of #75095 - pietroalbini:fallible-fast-fail, r=Mark-Simu… 

    …lacrum

ci: disable fast-fail on auto-fallible

The purpose of the auto-fallible job is to run builders that are likely to fail on CI without gating on them. Having fast-fail enabled there kinda defeats the purpose, as if one of them fails we can't monitor the outcome of the other ones.

This was prompted by the aarch64-gnu builder consistently failing due to a broken test, preventing us from seeing if the macOS spurious failure is fixed.

r? @Mark-Simulacrum
    @Manishearth
    Manishearth authored Aug 3, 2020

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    GPG key ID: 4AEE18F83AFDEB23
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    6bc70f1 View commit details

  10. Rollup merge of #75103 - Mark-Simulacrum:no-ra-for-riscv64, r=matklad 

    Disable building rust-analyzer on riscv64

riscv64 has an LLVM bug that makes rust-analyzer not build. Should permit future rust-analyzer ups (e.g., #74813) to land.
    @Manishearth
    Manishearth authored Aug 3, 2020

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    GPG key ID: 4AEE18F83AFDEB23
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    5aaf07a View commit details
Loading