From 6d50decba9a1b0f7b28a5ad63d1b9604af4f173c Mon Sep 17 00:00:00 2001 From: punker76 Date: Mon, 18 Nov 2019 21:07:54 +0100 Subject: [PATCH 1/2] (GH-3693) Moved the Attached HeaderProperties under HeaderedControlHelper for clarity --- .../ExampleViews/HamburgerMenuSample.xaml | 2 +- .../ExampleViews/TabControlExamples.xaml | 30 +++---- .../ExampleWindows/CleanWindowDemo.xaml | 4 +- .../ExampleWindows/FlyoutDemo.xaml | 2 +- .../Controls/Helper/ControlsHelper.cs | 82 ----------------- .../Controls/Helper/HeaderedControlHelper.cs | 87 +++++++++++++++++++ .../Styles/Clean/CleanGroupBox.xaml | 10 +-- .../Styles/Controls.Expander.xaml | 10 +-- .../Styles/Controls.GroupBox.xaml | 10 +-- .../Styles/Controls.TabControl.xaml | 18 ++-- .../Styles/Controls.ToggleSwitch.xaml | 2 +- src/MahApps.Metro/Styles/VS/Expander.xaml | 10 +-- src/MahApps.Metro/Styles/VS/GroupBox.xaml | 10 +-- src/MahApps.Metro/Styles/VS/TabControl.xaml | 8 +- src/MahApps.Metro/Themes/Flyout.xaml | 18 ++-- src/MahApps.Metro/Themes/MetroHeader.xaml | 14 +-- src/MahApps.Metro/Themes/MetroTabItem.xaml | 10 +-- src/MahApps.Metro/Themes/ToggleSwitch.xaml | 10 +-- .../Themes/WindowButtonCommands.xaml | 12 +-- 19 files changed, 177 insertions(+), 172 deletions(-) diff --git a/src/MahApps.Metro.Samples/MahApps.Metro.Demo/ExampleViews/HamburgerMenuSample.xaml b/src/MahApps.Metro.Samples/MahApps.Metro.Demo/ExampleViews/HamburgerMenuSample.xaml index 4d1e0a4b35..d46d493db5 100644 --- a/src/MahApps.Metro.Samples/MahApps.Metro.Demo/ExampleViews/HamburgerMenuSample.xaml +++ b/src/MahApps.Metro.Samples/MahApps.Metro.Demo/ExampleViews/HamburgerMenuSample.xaml @@ -21,7 +21,7 @@ diff --git a/src/MahApps.Metro.Samples/MahApps.Metro.Demo/ExampleViews/TabControlExamples.xaml b/src/MahApps.Metro.Samples/MahApps.Metro.Demo/ExampleViews/TabControlExamples.xaml index 502207aa8e..048682b057 100644 --- a/src/MahApps.Metro.Samples/MahApps.Metro.Demo/ExampleViews/TabControlExamples.xaml +++ b/src/MahApps.Metro.Samples/MahApps.Metro.Demo/ExampleViews/TabControlExamples.xaml @@ -121,8 +121,8 @@ + Controls:HeaderedControlHelper.HeaderFontFamily="Segoe Script" + Controls:HeaderedControlHelper.HeaderFontSize="18"> @@ -294,41 +294,41 @@ Style="{DynamicResource DescriptionHeaderStyle}" /> - - - - - - - @@ -342,7 +342,7 @@ - + - + - + - + - - + diff --git a/src/MahApps.Metro.Samples/MahApps.Metro.Demo/ExampleWindows/CleanWindowDemo.xaml b/src/MahApps.Metro.Samples/MahApps.Metro.Demo/ExampleWindows/CleanWindowDemo.xaml index 30c29f2a80..0368f9af09 100644 --- a/src/MahApps.Metro.Samples/MahApps.Metro.Demo/ExampleWindows/CleanWindowDemo.xaml +++ b/src/MahApps.Metro.Samples/MahApps.Metro.Demo/ExampleWindows/CleanWindowDemo.xaml @@ -121,7 +121,7 @@ - + @@ -23,10 +23,10 @@ ContentStringFormat="{TemplateBinding HeaderStringFormat}" ContentTemplate="{TemplateBinding HeaderTemplate}" ContentTemplateSelector="{TemplateBinding HeaderTemplateSelector}" - FontFamily="{TemplateBinding Controls:ControlsHelper.HeaderFontFamily}" - FontSize="{TemplateBinding Controls:ControlsHelper.HeaderFontSize}" - FontStretch="{TemplateBinding Controls:ControlsHelper.HeaderFontStretch}" - FontWeight="{TemplateBinding Controls:ControlsHelper.HeaderFontWeight}" + FontFamily="{TemplateBinding Controls:HeaderedControlHelper.HeaderFontFamily}" + FontSize="{TemplateBinding Controls:HeaderedControlHelper.HeaderFontSize}" + FontStretch="{TemplateBinding Controls:HeaderedControlHelper.HeaderFontStretch}" + FontWeight="{TemplateBinding Controls:HeaderedControlHelper.HeaderFontWeight}" Foreground="{TemplateBinding Controls:HeaderedControlHelper.HeaderForeground}" RecognizesAccessKey="True" SnapsToDevicePixels="{TemplateBinding SnapsToDevicePixels}" /> diff --git a/src/MahApps.Metro/Styles/Controls.Expander.xaml b/src/MahApps.Metro/Styles/Controls.Expander.xaml index f88c523032..82470edf3d 100644 --- a/src/MahApps.Metro/Styles/Controls.Expander.xaml +++ b/src/MahApps.Metro/Styles/Controls.Expander.xaml @@ -328,12 +328,12 @@ - + @@ -361,10 +361,10 @@ ContentStringFormat="{TemplateBinding HeaderStringFormat}" ContentTemplate="{TemplateBinding HeaderTemplate}" ContentTemplateSelector="{TemplateBinding HeaderTemplateSelector}" - FontFamily="{TemplateBinding Controls:ControlsHelper.HeaderFontFamily}" - FontSize="{TemplateBinding Controls:ControlsHelper.HeaderFontSize}" - FontStretch="{TemplateBinding Controls:ControlsHelper.HeaderFontStretch}" - FontWeight="{TemplateBinding Controls:ControlsHelper.HeaderFontWeight}" + FontFamily="{TemplateBinding Controls:HeaderedControlHelper.HeaderFontFamily}" + FontSize="{TemplateBinding Controls:HeaderedControlHelper.HeaderFontSize}" + FontStretch="{TemplateBinding Controls:HeaderedControlHelper.HeaderFontStretch}" + FontWeight="{TemplateBinding Controls:HeaderedControlHelper.HeaderFontWeight}" IsChecked="{Binding IsExpanded, Mode=TwoWay, RelativeSource={RelativeSource TemplatedParent}}" Style="{Binding RelativeSource={RelativeSource TemplatedParent}, Path=(Controls:ExpanderHelper.HeaderDownStyle)}" UseLayoutRounding="False"> diff --git a/src/MahApps.Metro/Styles/Controls.GroupBox.xaml b/src/MahApps.Metro/Styles/Controls.GroupBox.xaml index 47eb91ea11..e5a7fc3204 100644 --- a/src/MahApps.Metro/Styles/Controls.GroupBox.xaml +++ b/src/MahApps.Metro/Styles/Controls.GroupBox.xaml @@ -12,8 +12,8 @@ - + @@ -41,10 +41,10 @@ ContentStringFormat="{TemplateBinding HeaderStringFormat}" ContentTemplate="{TemplateBinding HeaderTemplate}" ContentTemplateSelector="{TemplateBinding HeaderTemplateSelector}" - FontFamily="{TemplateBinding Controls:ControlsHelper.HeaderFontFamily}" - FontSize="{TemplateBinding Controls:ControlsHelper.HeaderFontSize}" - FontStretch="{TemplateBinding Controls:ControlsHelper.HeaderFontStretch}" - FontWeight="{TemplateBinding Controls:ControlsHelper.HeaderFontWeight}" + FontFamily="{TemplateBinding Controls:HeaderedControlHelper.HeaderFontFamily}" + FontSize="{TemplateBinding Controls:HeaderedControlHelper.HeaderFontSize}" + FontStretch="{TemplateBinding Controls:HeaderedControlHelper.HeaderFontStretch}" + FontWeight="{TemplateBinding Controls:HeaderedControlHelper.HeaderFontWeight}" RecognizesAccessKey="True" SnapsToDevicePixels="{TemplateBinding SnapsToDevicePixels}" UseLayoutRounding="False"> diff --git a/src/MahApps.Metro/Styles/Controls.TabControl.xaml b/src/MahApps.Metro/Styles/Controls.TabControl.xaml index 21913ea5a6..d61f35b66b 100644 --- a/src/MahApps.Metro/Styles/Controls.TabControl.xaml +++ b/src/MahApps.Metro/Styles/Controls.TabControl.xaml @@ -9,7 +9,7 @@ - + @@ -104,10 +104,10 @@ - - - - + + + + @@ -150,11 +150,11 @@ ContentStringFormat="{TemplateBinding HeaderStringFormat}" ContentTemplate="{TemplateBinding HeaderTemplate}" ContentTemplateSelector="{TemplateBinding HeaderTemplateSelector}" - FontFamily="{TemplateBinding Controls:ControlsHelper.HeaderFontFamily}" - FontSize="{TemplateBinding Controls:ControlsHelper.HeaderFontSize}" - FontStretch="{TemplateBinding Controls:ControlsHelper.HeaderFontStretch}" + FontFamily="{TemplateBinding Controls:HeaderedControlHelper.HeaderFontFamily}" + FontSize="{TemplateBinding Controls:HeaderedControlHelper.HeaderFontSize}" + FontStretch="{TemplateBinding Controls:HeaderedControlHelper.HeaderFontStretch}" FontStyle="{TemplateBinding FontStyle}" - FontWeight="{TemplateBinding Controls:ControlsHelper.HeaderFontWeight}" + FontWeight="{TemplateBinding Controls:HeaderedControlHelper.HeaderFontWeight}" Foreground="{TemplateBinding Foreground}" RecognizesAccessKey="True" SnapsToDevicePixels="{TemplateBinding SnapsToDevicePixels}" diff --git a/src/MahApps.Metro/Styles/Controls.ToggleSwitch.xaml b/src/MahApps.Metro/Styles/Controls.ToggleSwitch.xaml index cf3df596d0..11b9353fcc 100644 --- a/src/MahApps.Metro/Styles/Controls.ToggleSwitch.xaml +++ b/src/MahApps.Metro/Styles/Controls.ToggleSwitch.xaml @@ -140,7 +140,7 @@ TargetType="{x:Type Controls:ToggleSwitch}"> - + diff --git a/src/MahApps.Metro/Styles/VS/Expander.xaml b/src/MahApps.Metro/Styles/VS/Expander.xaml index 8f2aaa1fcc..6ed1b238c2 100644 --- a/src/MahApps.Metro/Styles/VS/Expander.xaml +++ b/src/MahApps.Metro/Styles/VS/Expander.xaml @@ -328,12 +328,12 @@ - + @@ -355,10 +355,10 @@ ContentTemplate="{TemplateBinding HeaderTemplate}" ContentTemplateSelector="{TemplateBinding HeaderTemplateSelector}" DockPanel.Dock="Top" - FontFamily="{TemplateBinding Controls:ControlsHelper.HeaderFontFamily}" - FontSize="{TemplateBinding Controls:ControlsHelper.HeaderFontSize}" - FontStretch="{TemplateBinding Controls:ControlsHelper.HeaderFontStretch}" - FontWeight="{TemplateBinding Controls:ControlsHelper.HeaderFontWeight}" + FontFamily="{TemplateBinding Controls:HeaderedControlHelper.HeaderFontFamily}" + FontSize="{TemplateBinding Controls:HeaderedControlHelper.HeaderFontSize}" + FontStretch="{TemplateBinding Controls:HeaderedControlHelper.HeaderFontStretch}" + FontWeight="{TemplateBinding Controls:HeaderedControlHelper.HeaderFontWeight}" Foreground="{TemplateBinding Controls:HeaderedControlHelper.HeaderForeground}" IsChecked="{Binding IsExpanded, Mode=TwoWay, RelativeSource={RelativeSource TemplatedParent}}" SnapsToDevicePixels="{TemplateBinding SnapsToDevicePixels}" diff --git a/src/MahApps.Metro/Styles/VS/GroupBox.xaml b/src/MahApps.Metro/Styles/VS/GroupBox.xaml index e5af2cabc8..822dddc780 100644 --- a/src/MahApps.Metro/Styles/VS/GroupBox.xaml +++ b/src/MahApps.Metro/Styles/VS/GroupBox.xaml @@ -11,8 +11,8 @@ - + @@ -32,10 +32,10 @@ ContentStringFormat="{TemplateBinding HeaderStringFormat}" ContentTemplate="{TemplateBinding HeaderTemplate}" ContentTemplateSelector="{TemplateBinding HeaderTemplateSelector}" - FontFamily="{TemplateBinding Controls:ControlsHelper.HeaderFontFamily}" - FontSize="{TemplateBinding Controls:ControlsHelper.HeaderFontSize}" - FontStretch="{TemplateBinding Controls:ControlsHelper.HeaderFontStretch}" - FontWeight="{TemplateBinding Controls:ControlsHelper.HeaderFontWeight}" + FontFamily="{TemplateBinding Controls:HeaderedControlHelper.HeaderFontFamily}" + FontSize="{TemplateBinding Controls:HeaderedControlHelper.HeaderFontSize}" + FontStretch="{TemplateBinding Controls:HeaderedControlHelper.HeaderFontStretch}" + FontWeight="{TemplateBinding Controls:HeaderedControlHelper.HeaderFontWeight}" Foreground="{TemplateBinding Controls:HeaderedControlHelper.HeaderForeground}" RecognizesAccessKey="True" SnapsToDevicePixels="{TemplateBinding SnapsToDevicePixels}" /> diff --git a/src/MahApps.Metro/Styles/VS/TabControl.xaml b/src/MahApps.Metro/Styles/VS/TabControl.xaml index 8aa7bcf777..4fde255b2f 100644 --- a/src/MahApps.Metro/Styles/VS/TabControl.xaml +++ b/src/MahApps.Metro/Styles/VS/TabControl.xaml @@ -165,11 +165,11 @@ ContentStringFormat="{TemplateBinding HeaderStringFormat}" ContentTemplate="{TemplateBinding HeaderTemplate}" ContentTemplateSelector="{TemplateBinding HeaderTemplateSelector}" - FontFamily="{TemplateBinding Controls:ControlsHelper.HeaderFontFamily}" - FontSize="{TemplateBinding Controls:ControlsHelper.HeaderFontSize}" - FontStretch="{TemplateBinding Controls:ControlsHelper.HeaderFontStretch}" + FontFamily="{TemplateBinding Controls:HeaderedControlHelper.HeaderFontFamily}" + FontSize="{TemplateBinding Controls:HeaderedControlHelper.HeaderFontSize}" + FontStretch="{TemplateBinding Controls:HeaderedControlHelper.HeaderFontStretch}" FontStyle="{TemplateBinding FontStyle}" - FontWeight="{TemplateBinding Controls:ControlsHelper.HeaderFontWeight}" + FontWeight="{TemplateBinding Controls:HeaderedControlHelper.HeaderFontWeight}" Foreground="{TemplateBinding Foreground}" RecognizesAccessKey="True" SnapsToDevicePixels="{TemplateBinding SnapsToDevicePixels}" /> diff --git a/src/MahApps.Metro/Themes/Flyout.xaml b/src/MahApps.Metro/Themes/Flyout.xaml index b4ffd1af4d..28e5ddac6d 100644 --- a/src/MahApps.Metro/Themes/Flyout.xaml +++ b/src/MahApps.Metro/Themes/Flyout.xaml @@ -76,17 +76,17 @@ - - + + @@ -236,10 +236,10 @@ - + - + diff --git a/src/MahApps.Metro/Themes/MetroHeader.xaml b/src/MahApps.Metro/Themes/MetroHeader.xaml index c02c4bbedb..e5d2a04422 100644 --- a/src/MahApps.Metro/Themes/MetroHeader.xaml +++ b/src/MahApps.Metro/Themes/MetroHeader.xaml @@ -3,10 +3,10 @@ xmlns:Controls="clr-namespace:MahApps.Metro.Controls">