Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uno-skeletonmaker with --java5 option #154

Open
prrvchr opened this issue Mar 2, 2025 · 5 comments
Open

uno-skeletonmaker with --java5 option #154

prrvchr opened this issue Mar 2, 2025 · 5 comments

Comments

@prrvchr
Copy link
Contributor

prrvchr commented Mar 2, 2025

LOEclipse use uno-skeletonmaker with --java5 option to create a new (Java) Extension project (see file: /core/source/org/libreoffice/ide/eclipse/core/internal/model/UnoFactory.java)

I can't find a way to get rid of the:

  • __getComponentFactory( String sImplementationName )
  • __writeRegistryServiceInfo( XRegistryKey xRegistryKey )
    methods which is no longer needed by the UNO services in passive registration.

Maybe it is necessary to modify the source code of the utility uno-skeletonmaker itself?
Maybe we can use a tpl file in place of uno-skeletonmaker, but how about idl file?

Any good suggestion is welcome.

@smehrbrodt
Copy link
Contributor

Ok that needs fixing uno-skeletonmaker then.

@stbergmann Any insights here?

@stbergmann
Copy link

@stbergmann Any insights here?

Not really. Never looked into that uno-sekeletonmaker, nor into lo-eclipse (so don't even have any idea what that mentioned "tpl file" would be).

@prrvchr
Copy link
Contributor Author

prrvchr commented Mar 3, 2025

Ok that needs fixing uno-skeletonmaker then.

I'm afraid this has to be written in C++ and I think that's beyond my skills.

On the other hand I think that this would be the right way to do it since uno-skeletonmaker must be a tool allowing the use of the latest technology.

And it seems to me that a priori the services declared in passive registration mode make the installation of the extension and the instantiation of the UNO services much faster. I say well at first sight, I did not do any bench.

@prrvchr
Copy link
Contributor Author

prrvchr commented Mar 3, 2025

Everything is happening in skeletonmaker.cxx.
I think I will try to add a -pr or --passive-registration option which gets around the two unwanted methods.

@prrvchr
Copy link
Contributor Author

prrvchr commented Mar 3, 2025

Ok this has been done with PR#182436.
If anyone can verify and validate, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants