Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vararg param is mistakenly resolved as overriding #316

Closed
Schahen opened this issue Jun 23, 2020 · 2 comments
Closed

Vararg param is mistakenly resolved as overriding #316

Schahen opened this issue Jun 23, 2020 · 2 comments
Labels
domain:override missing overrides, redundant overrides, duplicate overrides etc.
Milestone

Comments

@Schahen
Copy link
Contributor

Schahen commented Jun 23, 2020

Following code:

./emitter.d.ts

declare module "emitter" {
    namespace EventEmitter {
            interface EventEmitter extends Core.EventEmitter {
            }   

            class EventEmitter {
            }   
    }   


    export = EventEmitter;
}

./core.d.ts

declare namespace Core {
     interface EventEmitter {
        emit(event: string | symbol, ...args: any[]): boolean;
    }
}

./index.d.ts

/// <reference path="./core.d.ts" />
/// <reference path="./emitter.d.ts" />

declare module "worker" {
import { EventEmitter } from "emitter";
 class Worker extends EventEmitter {
        emit(event: "error", err: Error): boolean;
        emit(event: "exit", exitCode: number): boolean;
        emit(event: "message", value: any): boolean;
        emit(event: "online"): boolean;
        emit(event: string | symbol, ...args: any[]): boolean;
 }
}

is translated however compilation fails with:

out/index.worker.module_node_4_minimal.kt:26:5: error: 'emit' overrides nothing
    override fun emit(event: String /* "message" */, value: Any): Boolean
    ^
@Schahen Schahen added the domain:override missing overrides, redundant overrides, duplicate overrides etc. label Jun 23, 2020
@Schahen Schahen added this to the 0.5.4 milestone Jun 23, 2020
@Schahen
Copy link
Contributor Author

Schahen commented Jun 23, 2020

A smaller example:
./emitter.d.ts

declare module "emitter" {
    export class EventEmitter {
        emit(event: string | symbol, ...args: any[]): boolean;
    }   
}

./index.d.ts

/// <reference path="./emitter.d.ts" />

declare module "worker" {
import { EventEmitter } from "emitter";
 class Worker extends EventEmitter {
        emit(event: "error", err: Error): boolean;
        emit(event: "exit", exitCode: number): boolean;
        emit(event: "message", value: any): boolean;
        emit(event: "online"): boolean;
        emit(event: string | symbol, ...args: any[]): boolean;
 }
}

@Schahen
Copy link
Contributor Author

Schahen commented Jun 23, 2020

And, predictably, even more a smaller example:

./index.d.ts

class EventEmitter {
    emit(event: string | symbol, ...args: any[]): boolean;
}   

class Worker extends EventEmitter {
    emit(event: "error", err: Error): boolean;
    emit(event: "exit", exitCode: number): boolean;
    emit(event: "message", value: any): boolean;
    emit(event: "online"): boolean;
    emit(event: string | symbol, ...args: any[]): boolean;
}

@Schahen Schahen changed the title Redundant override leads to a compilation error Vararg param is mistakingly treated as overriding Jun 23, 2020
@Schahen Schahen changed the title Vararg param is mistakingly treated as overriding Vararg param is mistakingly resolved as overriding Jun 23, 2020
@Schahen Schahen changed the title Vararg param is mistakingly resolved as overriding Vararg param is mistakenly resolved as overriding Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:override missing overrides, redundant overrides, duplicate overrides etc.
Projects
None yet
Development

No branches or pull requests

1 participant