Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kalert): kbutton text color within kalerts [KHCP-14565] #2571

Merged

Conversation

afrzhussain
Copy link
Contributor

JIRA ticket : https://konghq.atlassian.net/browse/KHCP-14565
Fixed Kalert modifying Kbutton text color when the button is of type external link( :to is sent in prop)

Copy link

netlify bot commented Jan 15, 2025

Deploy Preview for kongponents-sandbox ready!

Name Link
🔨 Latest commit 8c59787
🔍 Latest deploy log https://app.netlify.com/sites/kongponents-sandbox/deploys/6787e872ad7e110008b5c193
😎 Deploy Preview https://deploy-preview-2571--kongponents-sandbox.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 15, 2025

Deploy Preview for kongponents ready!

Name Link
🔨 Latest commit 8c59787
🔍 Latest deploy log https://app.netlify.com/sites/kongponents/deploys/6787e8721445480008dd9ba4
😎 Deploy Preview https://deploy-preview-2571--kongponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@kaiarrowood kaiarrowood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: the links are blue regardless of alert appearance (which I think is the point of this ticket), but it doesn't have a hover effect. Should the link text darken on hover?

@afrzhussain
Copy link
Contributor Author

afrzhussain commented Jan 15, 2025

question: the links are blue regardless of alert appearance (which I think is the point of this ticket), but it doesn't have a hover effect. Should the link text darken on hover?

It does have a small hover effect already

Comment on lines 131 to 132


Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

nit

Copy link
Collaborator

@kaiarrowood kaiarrowood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@afrzhussain afrzhussain merged commit 195ce77 into main Jan 15, 2025
10 checks passed
@afrzhussain afrzhussain deleted the KHCP-14565-k-button-text-color-within-k-alerts-isnt-correct branch January 15, 2025 17:26
kongponents-bot pushed a commit that referenced this pull request Jan 15, 2025
## [9.16.3](v9.16.2...v9.16.3) (2025-01-15)

### Bug Fixes

* **kalert:** kbutton text color within kalerts [KHCP-14565] ([#2571](#2571)) ([195ce77](195ce77))
@kongponents-bot
Copy link
Collaborator

🎉 This PR is included in version 9.16.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants