Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 2-arg include mapexpr to cache header? #54794

Open
timholy opened this issue Jun 14, 2024 · 0 comments
Open

Add 2-arg include mapexpr to cache header? #54794

timholy opened this issue Jun 14, 2024 · 0 comments

Comments

@timholy
Copy link
Member

timholy commented Jun 14, 2024

By my reading, a package file loaded with include(mapexpr, filename) does not preserve mapexpr in the cache header. This makes it hard for Revise to handle 2-arg include without defensively parsing the whole package, checking to see if there are any 2-arg includes.

For Revise to handle 2-arg include, at a minimum we probably need to annotate the header to say "this file was loaded with a 2-arg include," even if we don't store any information about mapexpr itself. This will allow Revise to skip defensive package parsing for the large majority of packages.

xref timholy/Revise.jl#634

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant