You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
By my reading, a package file loaded with include(mapexpr, filename) does not preserve mapexpr in the cache header. This makes it hard for Revise to handle 2-arg include without defensively parsing the whole package, checking to see if there are any 2-arg includes.
For Revise to handle 2-arg include, at a minimum we probably need to annotate the header to say "this file was loaded with a 2-arg include," even if we don't store any information about mapexpr itself. This will allow Revise to skip defensive package parsing for the large majority of packages.
By my reading, a package file loaded with
include(mapexpr, filename)
does not preservemapexpr
in the cache header. This makes it hard for Revise to handle 2-arginclude
without defensively parsing the whole package, checking to see if there are any 2-arginclude
s.For Revise to handle 2-arg
include
, at a minimum we probably need to annotate the header to say "this file was loaded with a 2-arginclude
," even if we don't store any information aboutmapexpr
itself. This will allow Revise to skip defensive package parsing for the large majority of packages.xref timholy/Revise.jl#634
The text was updated successfully, but these errors were encountered: