Skip to content

Commit b6dc05b

Browse files
authored
Change MaxDepth default to 64 (#2473)
1 parent 15525f1 commit b6dc05b

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

Src/Newtonsoft.Json.Tests/Serialization/JsonSerializerTest.cs

+3-3
Original file line numberDiff line numberDiff line change
@@ -8000,10 +8000,10 @@ public void NullableDoubleEmptyValue()
80008000
public void SetMaxDepth_DepthExceeded()
80018001
{
80028002
JsonTextReader reader = new JsonTextReader(new StringReader("[[['text']]]"));
8003-
Assert.AreEqual(128, reader.MaxDepth);
8003+
Assert.AreEqual(64, reader.MaxDepth);
80048004

80058005
JsonSerializerSettings settings = new JsonSerializerSettings();
8006-
Assert.AreEqual(128, settings.MaxDepth);
8006+
Assert.AreEqual(64, settings.MaxDepth);
80078007
Assert.AreEqual(false, settings._maxDepthSet);
80088008

80098009
// Default should be the same
@@ -8034,7 +8034,7 @@ public void SetMaxDepth_DepthNotExceeded()
80348034

80358035
serializer.Deserialize(reader);
80368036

8037-
Assert.AreEqual(128, reader.MaxDepth);
8037+
Assert.AreEqual(64, reader.MaxDepth);
80388038
}
80398039
}
80408040
}

Src/Newtonsoft.Json/JsonReader.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -329,7 +329,7 @@ protected JsonReader()
329329
_dateTimeZoneHandling = DateTimeZoneHandling.RoundtripKind;
330330
_dateParseHandling = DateParseHandling.DateTime;
331331
_floatParseHandling = FloatParseHandling.Double;
332-
_maxDepth = 128;
332+
_maxDepth = 64;
333333

334334
CloseInput = true;
335335
}

Src/Newtonsoft.Json/JsonSerializerSettings.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ public class JsonSerializerSettings
6161
internal static readonly CultureInfo DefaultCulture;
6262
internal const bool DefaultCheckAdditionalContent = false;
6363
internal const string DefaultDateFormatString = @"yyyy'-'MM'-'dd'T'HH':'mm':'ss.FFFFFFFK";
64-
internal const int DefaultMaxDepth = 128;
64+
internal const int DefaultMaxDepth = 64;
6565

6666
internal Formatting? _formatting;
6767
internal DateFormatHandling? _dateFormatHandling;

0 commit comments

Comments
 (0)